Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple addresses via CLI #1756

Closed
2 of 3 tasks
dB2510 opened this issue Feb 1, 2023 · 0 comments · Fixed by #1832
Closed
2 of 3 tasks

Support multiple addresses via CLI #1756

dB2510 opened this issue Feb 1, 2023 · 0 comments · Fixed by #1832
Assignees
@dB2510
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Feb 1, 2023 •
edited
Loading

🎯 Problem to be solved

We need to add support of multiple validator addresses with definition v1.5 via CLI flags.

🛠️ Proposed solution

Is there core team consensus on the proposed solution?

  • Yes
  • No

Detailed proposed solution

Replace following flags for create cluster and create dkg commands:

  • --fee-recipient-address => --fee-recipient-addresses
  • --withdrawal-address => --withdrawal-addresses

Update/add unit tests accordingly. Test these commands manually.

Note: This change needs v1.5 of cluster-definition to be live.

🧪 Tests

  • Test via automated unit/integration/smoke tests

👐 Additional acceptance criteria

None

❌ Out of Scope

None
@github-actions github-actions bot added the protocol Protocol Team tickets label Feb 1, 2023
@dB2510 dB2510 mentioned this issue Feb 24, 2023
Merged
@dB2510 dB2510 linked a pull request Feb 25, 2023 that will close this issue
cmd: add support for multiple addresses via cli #1832
Merged
obol-bulldozer bot pushed a commit that referenced this issue Feb 25, 2023
@dB2510
cmd: add support for multiple addresses via cli (#1832)
6e31013 
Adds support for multiple fee recipient address and withdrawal address via CLI with `create cluster` and `create dkg` commands.

category: feature
ticket: #1756
@dB2510 dB2510 mentioned this issue Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: add support for multiple addresses via cli ObolNetwork/charon
1 participant
@dB2510