Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require fee_recipient in commands #1613

Closed
corverroos opened this issue Jan 10, 2023 · 2 comments
Closed

Require fee_recipient in commands #1613

corverroos opened this issue Jan 10, 2023 · 2 comments
Assignees
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

Problem to be solved

Fee_recipient is optional in all commands: create dkg, create cluster, dkg.

This results in empty fee_recipient in charon run that results in warning logs:

Proposing block with unexpected fee recipient address {"expected": "", "actual": "0x0000000000000000000000000000000000000000", "duty": "4736088/proposer"}

Proposed solution

Either make it non-optional, so check it isn't empty.

Or make it default to withdrawal address, but this is implicit log and require documentation and warnings and stuff which isn't great.

@OisinKyne
Copy link
Contributor

Yeah lets not make a default nor should it be optional.

However if --definition-file is passed that overrides (all?) other flags, so its not needed then, but the definition-file should also assert that a fee_recipient is set.

Open Q: How might this flag work if we tried to make it compatible with multiple withdrawal addresses and multiple fee recipients? 🤔 CC @dB2510 (out of scope of this ticket though)

@thomasheremans thomasheremans added the protocol Protocol Team tickets label Jan 23, 2023
@dB2510 dB2510 self-assigned this Mar 27, 2023
@dB2510
Copy link
Contributor

dB2510 commented Mar 28, 2023

This is already done as part of #1756

@dB2510 dB2510 closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

4 participants