Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for verifying signatures for sync committee contribution duties #1264

Closed
xenowits opened this issue Oct 12, 2022 · 0 comments
Closed

Add support for verifying signatures for sync committee contribution duties #1264

xenowits opened this issue Oct 12, 2022 · 0 comments
Assignees
@dB2510
Labels
duties This issue is related to duties to be added

Comments

@xenowits
Copy link
Contributor

xenowits commented Oct 12, 2022 •
edited
Loading

Problem to be solved

Add signature verification for v2.SyncCommitteeSelectionRequest and altair.SignedContributionAndProof to the signing package (eth2util/signing/signing.go). This enables core components like validatorAPI and parsigex to verify signatures for sync committee contribution duties.

Proposed solution

Add a function with the following signature:

func VerifySyncCommitteeSelectionRequest(ctx context.Context, eth2Cl eth2wrap.Client, pubkey *bls_sig.PublicKey, r *v2.SyncCommitteeSelectionRequest) error {}

func VerifySyncContributionAndProof(ctx context.Context, eth2Cl eth2wrap.Client, pubkey *bls_sig.PublicKey, proof *altair.SignedContributionAndProof) error {}

Out of Scope

None.
@xenowits xenowits added the duties This issue is related to duties to be added label Oct 12, 2022
@xenowits xenowits changed the title Verify v2.SyncCommitteeSelectionRequest Add support for verifying signatures for sync committee contribution duties Oct 12, 2022
@dB2510 dB2510 mentioned this issue Oct 31, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 31, 2022
@dB2510
core: add verification for sync selection (#1373)
d2c0053 
Implement core.Eth2SignedData for SyncCommitteeSelection to support signature verification.

category: feature
ticket: #1264
@dB2510 dB2510 closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
duties This issue is related to duties to be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dB2510 @xenowits