Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add verification for sync selection #1373

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Oct 31, 2022

Implement core.Eth2SignedData for SyncCommitteeSelection to support signature verification.

category: feature
ticket: #1264

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 54.03% // Head: 54.18% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (2169d18) compared to base (1b09101).
Patch coverage: 44.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
+ Coverage   54.03%   54.18%   +0.14%     
==========================================
  Files         144      144              
  Lines       17507    17516       +9     
==========================================
+ Hits         9460     9491      +31     
+ Misses       6749     6726      -23     
- Partials     1298     1299       +1     
Impacted Files Coverage Δ
core/signeddata.go 46.74% <0.00%> (+3.88%) ⬆️
core/eth2signeddata.go 80.95% <100.00%> (+1.29%) ⬆️
app/peerinfo/peerinfo.go 54.48% <0.00%> (-3.45%) ⬇️
core/qbft/qbft.go 81.97% <0.00%> (+0.85%) ⬆️
app/vmock.go 75.40% <0.00%> (+1.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 31, 2022
@obol-bulldozer obol-bulldozer bot merged commit d2c0053 into main Oct 31, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/verifyselection branch October 31, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants