-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile & shell files lint #58
Conversation
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Azanul <[email protected]>
@Azanul can you fix lint errors. And make sure shell lint is working here. |
I did fix the errors but seems like I'll have to deal with warnings and style changes too |
Signed-off-by: Azanul <[email protected]>
@Azanul We could ignore |
I think I should add a hadolint config file too |
Signed-off-by: Azanul <[email protected]>
@Azanul remove the hadolint config file |
Convert
to
In Dockerfile |
Signed-off-by: Azanul <[email protected]>
i am not sure whether shell check actually ran or not ? |
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Azanul <[email protected]>
Yup Looks Like it is working. |
It that skepticism or joy? |
Joy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #50