Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile & shell files lint #58

Merged
merged 9 commits into from
Oct 6, 2023
Merged

Conversation

Azanul
Copy link
Contributor

@Azanul Azanul commented Oct 6, 2023

Fixes #50

@shubham-cmyk
Copy link
Member

shubham-cmyk commented Oct 6, 2023

@Azanul can you fix lint errors.

And make sure shell lint is working here.

@Azanul
Copy link
Contributor Author

Azanul commented Oct 6, 2023

@Azanul can you fix lint errors.

And make sure shell lint is working here.

I did fix the errors but seems like I'll have to deal with warnings and style changes too

@shubham-cmyk
Copy link
Member

@Azanul We could ignore DL3007,DL3018 here.

@Azanul
Copy link
Contributor Author

Azanul commented Oct 6, 2023

@Azanul We could ignore DL3007,DL3018 here.

I think I should add a hadolint config file too

@shubham-cmyk
Copy link
Member

@Azanul remove the hadolint config file

@shubham-cmyk
Copy link
Member

shubham-cmyk commented Oct 6, 2023

Convert

RUN curl -fL -Lo /tmp/redis-${REDIS_VERSION}.tar.gz ${REDIS_DOWNLOAD_URL}/redis-${REDIS_VERSION}.tar.gz && \
    cd /tmp && \
    tar xvzf redis-${REDIS_VERSION}.tar.gz && \
    cd redis-${REDIS_VERSION} && \
    make && \
    make install BUILD_TLS=yes

to

RUN curl -fL -Lo /tmp/redis-${REDIS_VERSION}.tar.gz ${REDIS_DOWNLOAD_URL}/redis-${REDIS_VERSION}.tar.gz && \
    tar xvzf redis-${REDIS_VERSION}.tar.gz

WORKDIR /tmp/redis-${REDIS_VERSION}

RUN make && \
    make install BUILD_TLS=yes

In Dockerfile
@Azanul

Signed-off-by: Azanul <[email protected]>
@shubham-cmyk
Copy link
Member

@Azanul

i am not sure whether shell check actually ran or not ?
How could run complete in 0s

image

Signed-off-by: Azanul <[email protected]>
@Azanul
Copy link
Contributor Author

Azanul commented Oct 6, 2023

Signed-off-by: Azanul <[email protected]>
@shubham-cmyk
Copy link
Member

shubham-cmyk commented Oct 6, 2023

@shubham-cmyk Looks like it's working

https://github.com/OT-CONTAINER-KIT/redis/actions/runs/6435805690/job/17477866384

Yup Looks Like it is working.
It is very fast though.

@Azanul
Copy link
Contributor Author

Azanul commented Oct 6, 2023

Yup Looks Like it is working. It is very fast though.

It that skepticism or joy?

@shubham-cmyk
Copy link
Member

Yup Looks Like it is working. It is very fast though.

It that skepticism or joy?

Joy.
I was not sure earlier maybe the runner is not able to calculate the time.

Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shubham-cmyk shubham-cmyk merged commit 7372305 into OT-CONTAINER-KIT:master Oct 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] : Improve the CI workflow by adding few more checks.
2 participants