Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] : Improve the CI workflow by adding few more checks. #50

Closed
shubham-cmyk opened this issue Sep 25, 2023 · 1 comment · Fixed by #58
Closed

[feat] : Improve the CI workflow by adding few more checks. #50

shubham-cmyk opened this issue Sep 25, 2023 · 1 comment · Fixed by #58
Assignees
@Azanul
Labels
hacktoberfest For hacktoberfest hacktoberfest-accepted

Comments

@shubham-cmyk
Copy link
Member

There are few improvement that can be done here.

  1. Docker file linter: https://github.com/hadolint/hadolint
  2. Bash script linter: https://github.com/koalaman/shellcheck

For the given Dockerfile and Scripts available in the repo.
@shubham-cmyk shubham-cmyk mentioned this issue Sep 25, 2023
Closed
@Azanul
Copy link
Contributor

Azanul commented Oct 3, 2023

May I take this up?

@Azanul Azanul mentioned this issue Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Azanul Azanul

Labels
hacktoberfest For hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dockerfile & shell files lint Azanul/redis
2 participants
@Azanul @shubham-cmyk