Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support redis-cluster topologySpreadConstraints(# 868) #1177

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

xiaozhuang-a
Copy link
Contributor

@xiaozhuang-a xiaozhuang-a commented Dec 20, 2024

Description

support redis-cluster topologySpreadConstraints(# #868)

Fixes #868

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 30.11%. Comparing base (60ef5a2) to head (cecd037).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
api/v1beta1/rediscluster_conversion.go 0.00% 12 Missing ⚠️
api/zz_generated.deepcopy.go 0.00% 10 Missing and 2 partials ⚠️
pkg/k8sutils/redis-cluster.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
- Coverage   30.20%   30.11%   -0.09%     
==========================================
  Files          55       55              
  Lines        6294     6428     +134     
==========================================
+ Hits         1901     1936      +35     
- Misses       4200     4292      +92     
- Partials      193      200       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer
Copy link
Collaborator

@xiaozhuang-a some pipeline failed :)

@xiaozhuang-a xiaozhuang-a changed the title support redis-cluster topologySpreadConstraints(# #868) feat: support redis-cluster topologySpreadConstraints(# #868) Dec 20, 2024
@xiaozhuang-a xiaozhuang-a changed the title feat: support redis-cluster topologySpreadConstraints(# #868) feat: support redis-cluster topologySpreadConstraints(# 868) Dec 20, 2024
xiaozhuang added 2 commits December 20, 2024 18:45
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
@xiaozhuang-a
Copy link
Contributor Author

@xiaozhuang-a some pipeline failed :)

it's ok

@drivebyer drivebyer enabled auto-merge (squash) December 21, 2024 05:30
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit ea98aa7 into OT-CONTAINER-KIT:master Dec 21, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support topologySpreadConstraints
2 participants