Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support topologySpreadConstraints #868

Closed
evrardjp opened this issue Apr 11, 2024 · 3 comments · Fixed by #1177
Closed

Support topologySpreadConstraints #868

evrardjp opened this issue Apr 11, 2024 · 3 comments · Fixed by #1177
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@evrardjp
Copy link

evrardjp commented Apr 11, 2024

Is your feature request related to a problem? Please describe.

Types have affinity/pdb, but do not have topologyspreadconstraints.
This is useful to split into multiple AZs.

Describe the solution you'd like

I guess add support of tsc into multiple places of the code.

Describe alternatives you've considered

Forking.

What version of redis-operator are you using?

redis-operator version: latest

Additional context

I am okay to implement it on my own. However, I would love to have the maintainers voice on:

  • Whether you are interested to have that feature in the operator
  • What parts of the code might be impacted, and what are the areas of attention [OPTIONAL]. In other words, if you can point me the way (to make my life easier, and avoid reverse engineering) I would love it.
    (Right now, I assume I need to update the CRD, its docs, the common types, redis-cluster, redis-types, redissentinel-types, redisreplication-types, redissentinel, statefulset, and the relative tests. Not sure about conversion go files)
@evrardjp evrardjp added the enhancement New feature or request label Apr 11, 2024
@evrardjp evrardjp changed the title Add topologySpreadConstraints into CRDs Support topologySpreadConstraints Apr 11, 2024
@drivebyer drivebyer self-assigned this Apr 25, 2024
@vramperez
Copy link

Any news? I would also be interested in this enhancement.

@xiaozhuang-a
Copy link
Contributor

+1

@drivebyer drivebyer added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 17, 2024
@CsongSY
Copy link

CsongSY commented Dec 18, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants