Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONDC Tech Logs - UPDATE #1513

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

srijit-prox
Copy link
Contributor

Issue #1507

@srijit-prox srijit-prox marked this pull request as ready for review April 17, 2024 10:20
@srijit-prox
Copy link
Contributor Author

@ashok-ai

@srijit-prox
Copy link
Contributor Author

Issues fixed:

Flow 1

/on_search
providers/location details are not correct
cancellation_terms must NOT have additional properties (refund_eligible)
return_location is not valid in return terms
providers/time is not a valid attribute
'POST-FULFILLMENT' is currently not enabled for B2B, should be removed from payments along with its mapping in /items
items/quantity/unitized/measure/value should be provided (why is it NA?), same goes for other 'value' fields
why are multiple g3 tags used in items/tags
num_price_slabs in g3 tag in /items has an invalid value
serviceability construct is not defined correctly (type, val, unit are not provided)
country of origin is missing in /items/tags
seller_terms tag is missing in providers/tags,
provide a valid 'seller_id_no' in 'seller_id' code - Not applicable for B2B
for domain RET10, why are category_ids used for RET15 in /items
FSSAI_LICENSE_NO is mandatory for RET10 - Not applicable for B2B
items/cancellation_terms/fulfillment_state/descriptor/code must be equal to one of the allowed values (Pending,Searching-for-Agent,Agent-assigned,Order-picked-up, Out-for-delivery)

/select
In /items , fulfillment_ids should be mapped to the selected fulfillment mode
'POST-FULFILLMENT' is currently not enabled

/on_select
In /items, fulfillment_ids should be mapped to the fulfillment id generated by the seller app
fulfillments/tags (DELIVERY_TERMS) are missing

/on_init
all terms should be included in bpp_terms tags

/on_confirm
'confirmed' is not a valid fulfillments/state/descriptor/code (should be 'Pending)

/on_status
"picked_up" is not an appropriate label for 'Invoice' in /documents
order/updated_at should be updated w.r.t context/timestamp for each fulfillment state update

Flow 2

/on_confirm
BPP should share the payment gateway link (payments/uri) along with TTL (payments/tags) for Prepaid order
Note: Flow 5 (Modified terms and conditions) needs to be provided as well

@ashok-ai
Copy link
Contributor

Hi @tanya-ondc ,

As discussed we are not taking any actions on the following issues,

  1. FSSAI_LICENSE_NO is mandatory for RET10.
  2. Mandatory - City, state, and country code. This is needed in the on_search API -> Provider/location .
  3. What are court_jurisdiction, max_liability_cap, max_liability, mandatory_arbitration, and delay_interest?
  4. Mandatory validation check for Tax-id, which is accepting only India Tax Id.
  5. Logs for cancellation flow

@tanya-ondc tanya-ondc merged commit 3209fef into ONDC-Official:main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants