Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxtera BPP v.2.0.2 - compliance check #1507

Open
abhinavv245 opened this issue Apr 4, 2024 · 9 comments
Open

Proxtera BPP v.2.0.2 - compliance check #1507

abhinavv245 opened this issue Apr 4, 2024 · 9 comments

Comments

@abhinavv245
Copy link
Collaborator

abhinavv245 commented Apr 4, 2024

Flow 1

/on_search

  • providers/location details are not correct
  • cancellation_terms must NOT have additional properties (refund_eligible)
  • return_location is not valid in return terms
  • providers/time is not a valid attribute
  • 'POST-FULFILLMENT' is currently not enabled for B2B, should be removed from payments along with its mapping in /items
  • items/quantity/unitized/measure/value should be provided (why is it NA?), same goes for other 'value' fields
  • why are multiple g3 tags used in items/tags
  • num_price_slabs in g3 tag in /items has an invalid value
  • serviceability construct is not defined correctly (type, val, unit are not provided)
  • country of origin is missing in /items/tags
  • seller_terms tag is missing in providers/tags,
  • provide a valid 'seller_id_no' in 'seller_id' code
  • for domain RET10, why are category_ids used for RET15 in /items
  • FSSAI_LICENSE_NO is mandatory for RET10
  • items/cancellation_terms/fulfillment_state/descriptor/code must be equal to one of the allowed values (Pending,Searching-for-Agent,Agent-assigned,Order-picked-up, Out-for-delivery)

/select

  • In /items , fulfillment_ids should be mapped to the selected fulfillment mode
  • 'POST-FULFILLMENT' is currently not enabled

/on_select

  • In /items, fulfillment_ids should be mapped to the fulfillment id generated by the seller app
  • fulfillments/tags (DELIVERY_TERMS) are missing

/on_init

  • all terms should be included in bpp_terms tags

/on_confirm

  • 'confirmed' is not a valid fulfillments/state/descriptor/code (should be 'Pending)

/on_status

  • "picked_up" is not an appropriate label for 'Invoice' in /documents
  • order/updated_at should be updated w.r.t context/timestamp for each fulfillment state update

Flow 2

  • similar issues as above

/on_confirm

  • BPP should share the payment gateway link (payments/uri) along with TTL (payments/tags) for Prepaid order

Note: Flow 5 (Modified terms and conditions) needs to be provided as well

@ashok-ai

srijit-prox added a commit to ashok-ai/verification-logs that referenced this issue Apr 17, 2024
tanya-ondc added a commit that referenced this issue Apr 22, 2024
@abhinavv245
Copy link
Collaborator Author

abhinavv245 commented Apr 24, 2024

Flow 1

/on_search

  • items/payment_ids - 3 is not applicable as it is not defined in the payments array
  • providers/creds are required for exports
  • SGD is not a valid country code for Singapore (SGP)
  • country code to be used for country of origin in items/tags
  • Location id/s L1 in /items does not exist in /providers/locations
  • time_to_ship in g2 cannot be an empty string

/on_select

  • ttl should be kept constant PT30S in all /on_action APIs
  • provider_id is an invalid attribute in /fulfillments

/on_confirm

  • invalid bap_terms in order/tags, duplicate bpp_terms (all the terms should be listed under one bpp_terms tag if provided)
  • context/timestamp difference between on_confirm and confirm should be within 5 seconds
  • provider/ttl is not required (in on_status as well)

Flow 2

  • similar issues

/on_confirm

  • payments/uri (not URI) and payments/tags (dsa and signature as well) are required when BPP is collecting prepaid payment

@ashok-ai

srijit-prox added a commit to ashok-ai/verification-logs that referenced this issue May 1, 2024
tanya-ondc added a commit that referenced this issue May 2, 2024
@abhinavv245
Copy link
Collaborator Author

Flow 1

/on_init

  • context/ttl must be equal to constant (PT30S)

/on_confirm

  • fulfillments/start/location/id - L1 is not matching with the provider location id - P_L1 provided in /on_search"

Flow 5

/on_select (reject)

  • Appropriate error code to be used for buyer terms not acceptable

@ashok-ai

srijit-prox added a commit to ashok-ai/verification-logs that referenced this issue May 3, 2024
tanya-ondc added a commit that referenced this issue May 3, 2024
srijit-prox added a commit to ashok-ai/verification-logs that referenced this issue May 7, 2024
@tanyamadaan
Copy link
Collaborator

  • How do you verify the zip codes. For ex. is "area_code": "0213280" a valid ghana zip code?
  • on_search - "platform_id" - invalid attribute in providers.items
  • on_search - provider.tags.seller_id - cannot be gst. Probably, it would be tin.
  • on_search - provider.tags.seller_terms.gst_credit_invoice - cannot be Y.
  • on_select - "@ondc/org/TAT" = P1D. Are you validating this?

Flow 2 and 4 are not valid as prepaid payment is not yet enabled for B2B Exports

@ashok-ai

@srijit-prox
Copy link
Contributor

Hi @tanyamadaan the changes has been made and already merged.
@abhinavv245 @ashok-ai

@tanyamadaan
Copy link
Collaborator

@srijit-prox I can see the latest logs from May7th only. Can you please submit the latest logs.

@srijit-prox
Copy link
Contributor

@tanyamadaan can you check this PR?
#1524

@tanyamadaan
Copy link
Collaborator

I have already checked this PR @srijit-prox Can you please test the flows and submit latest logs.

srijit-prox added a commit to ashok-ai/verification-logs that referenced this issue Oct 1, 2024
tanyamadaan added a commit that referenced this issue Oct 7, 2024
@tanyamadaan
Copy link
Collaborator

tanyamadaan commented Oct 7, 2024

##Flow1

/on_search:

  • Please use a valid UPC/EAN/any custom code for items.descriptor.code. Use

/on_select:

  • COMM_CHANNEL tag group should not be present in on_select.

/on_init:

  • Is proxtera sure of the cancellation terms being sent as part of on_search and on_init?

Flow 6

/on_select

•⁠ ⁠In /items, 'quantity' mismatch from /select for item with id 66fbfca90d808f50539f46be

@srijit-prox

srijit-prox added a commit to ashok-ai/verification-logs that referenced this issue Oct 9, 2024
tanyamadaan added a commit that referenced this issue Oct 10, 2024
@tanyamadaan
Copy link
Collaborator

BPP v2.0.2 Logs approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants