Add commandline option to simulate alert queue expand failure - v2 #7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2022
victorjulien
previously approved these changes
Jun 10, 2022
For testing purposes. Meant to simulate a reallocation failure when dynamically growing the alert queue in DetectEngineThreadCtx, so we can check that Suri's behavior doesn't break under such circumstances. Task OISF#5319
jufajardini
force-pushed
the
alert-expand-fail-5319/v2
branch
from
be7b364
to
ccb35a7
Compare
|
Force pushed to fix the commit checks, as I had fixed the include typo but in the wrong commit... Sorry about that >__< |
|
Information: QA ran without warnings. Pipeline 7791 |
|
Information: QA ran without warnings. Pipeline 7793 |
jlucovsky
reviewed
Jun 28, 2022
| @@ -27,6 +27,7 @@ | |||
| #include "flow.h" | |||
| #include "flow-private.h" | |||
|
|
|||
| #include "util-exception-policy.h" | |||
There was a problem hiding this comment.
Should this be guarded with ifdef DEBUG?
There was a problem hiding this comment.
Following Victor's example, this wasn't there, but I think it is a good addition, indeed.
|
replaced by: #7622 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #7403
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5319
Describe changes:
--simulate-alert-queue-realloc-failureas part of the exception utils optionssuricata-verify-pr: 850
OISF/suricata-verify#850