Add commandline option to simulate alert queue expand failure- v1 #7403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For testing purposes. Meant to simulate a reallocation failure when dynamically growing the alert queue in DetectEngineThreadCtx, so we can check that Suri's behavior doesn't break under such circumstances. Task OISF#5319
| @@ -221,7 +221,10 @@ void AlertQueueFree(DetectEngineThreadCtx *det_ctx) | |||
| static uint16_t AlertQueueExpand(DetectEngineThreadCtx *det_ctx) | |||
| { | |||
There was a problem hiding this comment.
A check like below the start of the function would make more sense to me:
static uint16_t AlertQueueExpand(DetectEngineThreadCtx *det_ctx)
{
#ifdef DEBUG
if (unlikely(is_alert_queue_fail_mode))
return det_ctx->alert_queue_capacity;
#endif
... rest of the func ...
|
I think it would make sense to model the option after the work here https://github.com/OISF/suricata/pull/7393/files#diff-dc589ac7f5fdeb0157360264d2fa5a02574ee3359be4841a0a59f333d33e06abR116 |
|
ERROR: ERROR: QA failed on tlpw1_files_sha256. ERROR: QA failed on tlpr1_alerts_cmp. Pipeline 7472 |
|
Replaced by: #7527 |
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Nov 20, 2024
To be used by the requires keyword to check for keyword support. Ticket: OISF#7403
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Nov 20, 2024
For example:
requires: keyword foo;
Will require that Suricata supports the "foo" keyword.
Ticket: OISF#7403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5319
Describe changes:
--disable-alert-queue-expandthat, when passed as an argument, will skip reallocating the alert queue, once it reaches packet alert max. This allows for one to test Suri behavior if reallocating fails.This must merged after #7396 as it exposes bug 5353
suricata-verify-pr: 825
OISF/suricata-verify#825