Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next/20200824/v2 #5317

Merged
merged 5 commits into from
Aug 24, 2020
Merged

Next/20200824/v2 #5317

merged 5 commits into from
Aug 24, 2020

Conversation

victorjulien
Copy link
Member

@jasonish
github-ci: add autoreconf to centos-7 build
0de0c60 
The prepared distribution packages are failing autoreconf
due to a missing acsite.m4. Add autoreconf to the centos-7
build which uses the prepared package to test for this
issue.
@jasonish
automake: add acsite.m4 to EXTRA_DIST
507ed59 
This file is required to successfully re-run autoreconf, which
many packaging tools will do even on a prepared distribution
archive.
@jasonish @victorjulien
output-json: fix Coverity USE_AFTER_FREE
f2a1626 
Return error if plugin open fails. Fixes Coverity CID 1465664
USE_AFTER_FREE error.

Redmine issue:
https://redmine.openinfosecfoundation.org/issues/3864
@jasonish @victorjulien
plugins: use closedir to close open directory (not free)
dbb5dcb 
Found by Coverity, CID 1465665: ALLOC_FREE_MISMATCH.

Redmine issue:
https://redmine.openinfosecfoundation.org/issues/3864
@jasonish @victorjulien
plugins: track all loaded plugins in a list
b8994cd 
Track the pointer returned from dlopen in a list to prevent a
resource leak by the pointer going out of scope.

Found by Coverity, CID 1465661.

Redmine issue:
https://redmine.openinfosecfoundation.org/issues/3864
@victorjulien victorjulien requested a review from a team as a code owner August 24, 2020 11:32
@victorjulien victorjulien merged commit b8994cd into OISF:master Aug 24, 2020
@victorjulien victorjulien mentioned this pull request Aug 24, 2020
Closed
@victorjulien victorjulien deleted the next/20200824/v2 branch October 9, 2020 08:07
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 2, 2022
@catenacyber
flow: compute stat counters again
58d7223 
As broken by b359950
Variables like FlowTimeoutCounters.clo was always 0 and never
changed.

Ticket: OISF#5317
catenacyber added a commit to catenacyber/suricata that referenced this pull request Aug 29, 2022
@catenacyber
flow: finish to remove obsolete counters
d69c597 
As was begun in b359950

Ticket: OISF#5317
catenacyber added a commit to catenacyber/suricata that referenced this pull request Aug 29, 2022
@catenacyber
flow: finish to remove obsolete counters
7e54404 
As was begun in b359950

Ticket: OISF#5317
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Aug 30, 2022
@catenacyber @victorjulien
flow: finish to remove obsolete counters
b0ce55c 
As was begun in b359950

Ticket: OISF#5317
benignbala pushed a commit to benignbala/suricata that referenced this pull request Nov 12, 2022
@catenacyber @benignbala
flow: finish to remove obsolete counters
4af8f00 
As was begun in b359950

Ticket: OISF#5317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorjulien @jasonish