plugins: resolve coverity issues - v1 #5312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return error if plugin open fails. Fixes Coverity CID 1465664 USE_AFTER_FREE error. Redmine issue: https://redmine.openinfosecfoundation.org/issues/3864
Found by Coverity, CID 1465665: ALLOC_FREE_MISMATCH. Redmine issue: https://redmine.openinfosecfoundation.org/issues/3864
Track the pointer returned from dlopen in a list to prevent a resource leak by the pointer going out of scope. Found by Coverity, CID 1465661. Redmine issue: https://redmine.openinfosecfoundation.org/issues/3864
victorjulien
approved these changes
Aug 24, 2020
Merged
|
Merged in #5317, thanks Jason! |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
May 9, 2022
Since GCC 12 the memcmp code using `_mm_blendv_epi8` failed to work. Inspection of the disassembled objects suggests that it simply omits the instruction on systems that are not AVX512 capable. On AVX512 it does replace it with VPCMPB logic that appears to work. Luckily our use of blend is actually uncessary. A simple AND is sufficient. Bug: OISF#5312.
jufajardini
pushed a commit
to jufajardini/suricata
that referenced
this pull request
May 17, 2022
Since GCC 12 the memcmp code using `_mm_blendv_epi8` failed to work. Inspection of the disassembled objects suggests that it simply omits the instruction on systems that are not AVX512 capable. On AVX512 it does replace it with VPCMPB logic that appears to work. Luckily our use of blend is actually uncessary. A simple AND is sufficient. Bug: OISF#5312.
jlucovsky
pushed a commit
to jlucovsky/suricata
that referenced
this pull request
May 26, 2022
Since GCC 12 the memcmp code using `_mm_blendv_epi8` failed to work. Inspection of the disassembled objects suggests that it simply omits the instruction on systems that are not AVX512 capable. On AVX512 it does replace it with VPCMPB logic that appears to work. Luckily our use of blend is actually uncessary. A simple AND is sufficient. Bug: OISF#5312. (cherry picked from commit 87c5d69)
jlucovsky
pushed a commit
to jlucovsky/suricata
that referenced
this pull request
May 27, 2022
Since GCC 12 the memcmp code using `_mm_blendv_epi8` failed to work. Inspection of the disassembled objects suggests that it simply omits the instruction on systems that are not AVX512 capable. On AVX512 it does replace it with VPCMPB logic that appears to work. Luckily our use of blend is actually uncessary. A simple AND is sufficient. Bug: OISF#5312. (cherry picked from commit 87c5d69)
jlucovsky
pushed a commit
to jlucovsky/suricata
that referenced
this pull request
May 31, 2022
Since GCC 12 the memcmp code using `_mm_blendv_epi8` failed to work. Inspection of the disassembled objects suggests that it simply omits the instruction on systems that are not AVX512 capable. On AVX512 it does replace it with VPCMPB logic that appears to work. Luckily our use of blend is actually uncessary. A simple AND is sufficient. Bug: OISF#5312. (cherry picked from commit 87c5d69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Coverity issues in https://redmine.openinfosecfoundation.org/issues/3864
with the exception of CID 1465662.