Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS keyword cleanup #3853

Closed
wants to merge 18 commits into from
Closed

TLS keyword cleanup #3853

wants to merge 18 commits into from

Conversation

thus
Copy link
Contributor

@thus thus commented May 14, 2019

Do a cleanup of TLS keywords based on comments in #3545:

Prscript:

thus added 18 commits May 14, 2019 07:55
@thus
userguide: 'sticky' instead of 'Sticky' for all tls keywords
7e4df19
@thus
detect-tls: remove confusing underscores from variables
e5240cb 
Remove confusing underscore prefix from variables in GetData() for
all tls keywords.
@thus
detect-tls: check return values of functions on setup
a27434b 
Check the return values of DetectBufferSetActiveList() and
DetectSignatureSetAppProto().
@thus
detect-tls: declare ssl_state as const in GetData()
7a68c87
@thus
detect-tls: remove NULL settings from keyword registration
d21ae4c
@thus
ja3: check if JA3 is disabled on one line
7086db2
@thus
detect-tls: tidy up unittests
518549b 
By doing the following:
- removing unnecessary locks
- moving variable declarations
- removing redundant function 'SigCleanSignatures'
@thus
detect-tls-cert-fingerprint: move unittests to tests/
5a1dc75
@thus
detect-tls-cert-issuer: move unittests to tests/
8541e08
@thus
detect-tls-cert-serial: move unittests to tests/
8abce2e
@thus
detect-tls-cert-subject: move unittests to tests/
0021080
@thus
detect-tls-ja3-hash: move unittests to tests/
3589a24
@thus
detect-tls-ja3-string: move unittests to tests/
ec6e544
@thus
detect-tls-sni: move unittests to tests/
46e4d2c
@thus
detect-tls-cert-validity: move unittests to tests/
753ef8d
@thus
detect-tls-version: move unittests to tests/
8b43423
@thus
detect-ssl-state: move unittests to tests/
95ab57d
@thus
detect-ssl-version: move unittests to tests/
fc353d4
@thus thus requested review from norg and a team as code owners May 14, 2019 14:13
@victorjulien victorjulien mentioned this pull request May 20, 2019
Merged
@victorjulien
Copy link
Member

Merged in #3868, thanks Mats!

@victorjulien victorjulien mentioned this pull request May 22, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norg norg Awaiting requested review from norg

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thus @victorjulien