Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust add snmp 02 #3879

Closed
wants to merge 12 commits into from
Closed

Rust add snmp 02 #3879

wants to merge 12 commits into from

Conversation

chifflier
Copy link
Contributor

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2738

This is an update of #3581

Describe changes (since last PR):

  • Upgrade to nom4 (inner parser crate was also updated)
  • Rebase to match changes
  • Rename keywords (snmp_version -> snmp.version, etc.)

There will also be a matching suricata-verify pull request with test files.

doc/userguide/rules/snmp-keywords.rst Show resolved Hide resolved
rust/src/snmp/detect.rs Show resolved Hide resolved
rust/src/snmp/log.rs Show resolved Hide resolved
src/app-layer-snmp.c Show resolved Hide resolved
src/app-layer-snmp.h Show resolved Hide resolved
src/detect-snmp-pdu_type.c Show resolved Hide resolved
src/detect-snmp-pdu_type.c Show resolved Hide resolved
src/detect-snmp-version.c Show resolved Hide resolved
src/detect-snmp-version.c Show resolved Hide resolved
src/detect-snmp-version.c Show resolved Hide resolved
@chifflier chifflier mentioned this pull request May 22, 2019
3 tasks
@chifflier
Copy link
Contributor Author

Thanks, all requested changes merged.
Closing pr, superseded by #3883

@chifflier chifflier closed this May 22, 2019
@chifflier chifflier mentioned this pull request Jun 6, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants