detect: absent keyword to test absence of sticky buffer 2224 v23 #11906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DetectEngineInspectBufferHttpHeader is only used with ALPROTO_HTTP1 - engine->progress should be HTP_REQUEST_HEADERS or HTP_RESPONSE_HEADERS based on the direction
catenacyber
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11906 +/- ##
==========================================
- Coverage 82.60% 79.18% -3.42%
==========================================
Files 912 912
Lines 249342 249070 -272
==========================================
- Hits 205968 197228 -8740
- Misses 43374 51842 +8468
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23045 |
Ticket: 2224 It takes an argument to match only if the buffer is absent, or it can still match if the buffer is present, but we test the absence of some content. For multi buffers, absent matches if there are 0 buffers. For file keywords, absent matches if there is no file.
catenacyber
force-pushed
the
detect-negated-content-absent-buffer-2224-v23
branch
from
5cbee48
to
cdd48e4
Compare
|
Force-pushed with just the commit reworded. Still the question of transforms : do you see a use case of buffer + transform + absent keyword ? |
5 tasks
|
Information: QA ran without warnings. Pipeline 23073 |
|
Clean in #11964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2224
Describe changes:
absentkeyword to match on absent bufferSV_BRANCH=OISF/suricata-verify#1957
#11509 with code review taken into account