-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests for negated content and absent keyword #1957
Open
catenacyber
wants to merge
1
commit into
OISF:master
Choose a base branch
from
catenacyber:detect-negated-content-absent-buffer-2224-v10
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adds tests for negated content and absent keyword #1957
catenacyber
wants to merge
1
commit into
OISF:master
from
catenacyber:detect-negated-content-absent-buffer-2224-v10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2024
inashivb
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good. 🌟
Gonna take another pass at the Suricata code before approving.
catenacyber
force-pushed
the
detect-negated-content-absent-buffer-2224-v10
branch
2 times, most recently
from
July 10, 2024 06:33
cfd4011
to
012c150
Compare
inashivb
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Having the |
catenacyber
force-pushed
the
detect-negated-content-absent-buffer-2224-v10
branch
from
July 15, 2024 19:04
012c150
to
a4c53c8
Compare
catenacyber
force-pushed
the
detect-negated-content-absent-buffer-2224-v10
branch
from
October 8, 2024 15:04
a4c53c8
to
716a90a
Compare
This was referenced Oct 8, 2024
victorjulien
approved these changes
Nov 7, 2024
Ticket: 2224
catenacyber
force-pushed
the
detect-negated-content-absent-buffer-2224-v10
branch
from
November 12, 2024 15:41
716a90a
to
3ec563b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/2224
#1942 with more tests