Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for negated content and absent keyword #1957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Collaborator

Ticket

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/2224

#1942 with more tests

  • engine analysis test
  • checks with absent keyword and positive content

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good. 🌟
Gonna take another pass at the Suricata code before approving.

@catenacyber catenacyber force-pushed the detect-negated-content-absent-buffer-2224-v10 branch 2 times, most recently from cfd4011 to 012c150 Compare July 10, 2024 06:33
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jufajardini
Copy link
Contributor

Having the engine-analysis test is nice, thanks! :)

@catenacyber catenacyber force-pushed the detect-negated-content-absent-buffer-2224-v10 branch from 716a90a to 3ec563b Compare November 12, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires suricata pr Depends on a PR in Suricata
Development

Successfully merging this pull request may close these issues.

4 participants