Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode/ethertype: Event on unknown ethertype #11546

Closed
wants to merge 2 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11455

Issue: 7129

Create a decode/engine event if unknown ethertypes are observed.

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7129

Describe changes:

  • Add an event created when unknown ethertypes are observed
  • Update schema with event counter
  • Add rule for event.

Updates

  • The events are no longer counted under the decoder.invalid stats; the existing decoder.unknown_ethertype stat is used.

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=OISF/suricata-verify#1954
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Issue: 7129

Create a decode/engine event if unknown ethertypes are observed.
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.46%. Comparing base (7f6c963) to head (09454b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11546      +/-   ##
==========================================
- Coverage   82.51%   82.46%   -0.06%     
==========================================
  Files         923      923              
  Lines      248732   248739       +7     
==========================================
- Hits       205232   205113     -119     
- Misses      43500    43626     +126     
Flag Coverage Δ
fuzzcorpus 60.44% <100.00%> (+0.04%) ⬆️
livemode 18.79% <100.00%> (+0.16%) ⬆️
pcap 43.99% <100.00%> (-0.09%) ⬇️
suricata-verify 61.67% <100.00%> (-0.09%) ⬇️
unittests 59.06% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21694

@jlucovsky
Copy link
Contributor Author

Continued in #11557

@jlucovsky jlucovsky closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants