tests/decode: Verify unknown ethertype event #1954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
catenacyber
reviewed
Jul 19, 2024
| @@ -1,5 +1,6 @@ | |||
| requires: | |||
| min-version: 7 | |||
| lt-version: 8 | |||
There was a problem hiding this comment.
Why do we need this ? (deserves a comment maybe)
There was a problem hiding this comment.
Will add a readme file for this test explaining things.
There was a problem hiding this comment.
Unresolving until a README is added then
catenacyber
reviewed
Jul 19, 2024
| match: | ||
| event_type: anomaly | ||
| anomaly.type: decode | ||
| anomaly.event: decoder.ethernet.unknown_ethertype |
There was a problem hiding this comment.
do we have the unknown ether type logged ?
There was a problem hiding this comment.
No, the unknown value is not logged
There was a problem hiding this comment.
Hmmm... How could we get it ?
There was a problem hiding this comment.
I guess pcap logging would be one way to get it...
There was a problem hiding this comment.
Is not ether.ether_type: 47099 what we want ?
This was referenced Jul 24, 2024
Issue: 7129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 7129
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7129