Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnint 64to32 6186 v20.3 #11422

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186

Describe changes:

  • fix -Wshorten-64-to-32 warnings for some files (c*, f*)

Some commits of #9840
#11257 next batch

#11416 with reviews taken into account for flow manager

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21366

@catenacyber
Copy link
Contributor Author

Force-pushing just a rebase to check greener CI (with latest suricata meter for latest SV)

THashInitConfig may not allocate array and increase memuse.
Such a failure leads to THashShutdown which should not decrease
the memuse.

Ticket: 7135
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.44%. Comparing base (a7af371) to head (6040b0c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11422      +/-   ##
==========================================
- Coverage   82.44%   82.44%   -0.01%     
==========================================
  Files         938      938              
  Lines      248086   248086              
==========================================
- Hits       204534   204533       -1     
- Misses      43552    43553       +1     
Flag Coverage Δ
fuzzcorpus 60.10% <73.33%> (ø)
livemode 18.72% <80.00%> (ø)
pcap 43.72% <66.66%> (-0.06%) ⬇️
suricata-verify 61.43% <80.00%> (+0.01%) ⬆️
unittests 59.43% <13.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien marked this pull request as draft July 4, 2024 13:42
@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

ERROR: QA failed on SURI_TLPR1_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 137 145 105.84%
SURI_TLPR1_stats_chk
.uptime 642 672 104.67%

Pipeline 21389

@catenacyber
Copy link
Contributor Author

Rebased in #11453

@catenacyber catenacyber closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants