Warnint 64to32 6186 v19.6 #11257
Warnint 64to32 6186 v19.6 #11257
Conversation
Ticket: 6186 Warnings about downcast from 64 to 32 bits Generic fixes required to get app-layer clean
Ticket: OISF#6186 Warnings about downcast from 64 to 32 bits
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11257 +/- ##
==========================================
- Coverage 82.99% 82.98% -0.01%
==========================================
Files 942 942
Lines 249358 249384 +26
==========================================
+ Hits 206951 206958 +7
- Misses 42407 42426 +19
Flags with carried forward coverage won't be shown. Click here to find out more. |
| c->container->lastsize = f->size; | ||
| HttpRangeFileClose(sbcfg, c->container, flags | FILE_TRUNCATED); | ||
| c->container->error = true; | ||
| return f; | ||
| } | ||
| } | ||
| if (FileAppendData(c->container->files, sbcfg, range->buffer, range->offset) != 0) { | ||
| if (range->offset > UINT32_MAX) { |
There was a problem hiding this comment.
does this mean we can't support ranges for files > 4GiB?
There was a problem hiding this comment.
No, that means we do not support ranges >4GiB for files
For example, We support a 15 GiB file if it is split into 15 1GiB ranges (but util-file.c has the DEBUG_VALIDATE_BUG_ON(data_len > BIT_U32(26)); // 64MiB as a limit per chunk seems already excessive in this case)
We do not support this 15 GiB file if it is split into 3 5GiB files, because FileAppendData only accepts a u32
There was a problem hiding this comment.
Ok this seems like something we need to fix, but that can be in another effort
|
Information: QA ran without warnings. Pipeline 21008 |
|
Merged in #11353, thanks! |
[Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32warnings for some files (a*)First commit of #9840
#11247 with review taken into account