Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes hydration functions from seg and rt extensions #3585

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

rodrigobasilio2022
Copy link
Collaborator

@rodrigobasilio2022 rodrigobasilio2022 commented Aug 9, 2023

This PR is related to the issue #3356, and exposes hydration functions to be used in an IDC mode that auto hydrates derived series (SEG, RTSTRUCT, SR) when user opens the main series.

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit b11a897
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64d3aeff30f8860008a1c865
😎 Deploy Preview https://deploy-preview-3585--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit b11a897
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64d3aeff5796dd000823200c
😎 Deploy Preview https://deploy-preview-3585--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3585 (b11a897) into master (5d43542) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3585   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1287d...b11a897. Read the comment docs.

@sedghi
Copy link
Member

sedghi commented Aug 9, 2023

This does not belong here. This should be the mode in the IDC mode/extension repo (not fork, just mode/extension repo that you should have similar to what radicalImaging have here

Only pieces of it that relates to the core should be put as the PR

@rodrigobasilio2022 rodrigobasilio2022 added the IDC:priority Items that the Imaging Data Commons wants to help sponsor label Aug 9, 2023
@rodrigobasilio2022
Copy link
Collaborator Author

rodrigobasilio2022 commented Aug 9, 2023

Understand that. Do you think the file modes/autoload/src/loadDerivedDisplaySets.ts could be leaved in main repo to allow auto hydration or no? The plan was to merge only the necessary files. The mode created is only for show the functionality and will be removed before merge

@rodrigobasilio2022 rodrigobasilio2022 changed the title Creates a new mode that auto hydrates derived sequences Exposes hydrantion functions from seg and rt extensions Aug 9, 2023
@rodrigobasilio2022 rodrigobasilio2022 changed the title Exposes hydrantion functions from seg and rt extensions Exposes hydration functions from seg and rt extensions Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants