Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Auto load derived display sets when opening series #3356

Closed
igoroctaviano opened this issue May 3, 2023 · 8 comments
Closed
Assignees
Labels
Feature Request IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority

Comments

@igoroctaviano
Copy link
Contributor

igoroctaviano commented May 3, 2023

Request

Derived display sets are automatically loaded when the series is open in the viewport instead of double-clicking in the derived display set thumbnail in the left panel and accepting the hydration through a dialog

Context

In OHIF v2 when clicking on a series with derived display sets, all derived data loads automatically.
This is useful for read-only viewers that do not require the hydration workflow in v3, and just want all data related to a given loaded series to be displayed instantly.

Possible solutions

  • Add a new hanging protocol option to automatically load derived display sets for series being loaded in the viewport which would disable all hydration dialogs
  • Add a new option to the viewer configuration
@igoroctaviano igoroctaviano added Community: Request ✋ IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority labels May 3, 2023
@igoroctaviano igoroctaviano changed the title Auto Hydration of Segmentation in v3 v3: Auto Hydration of Segmentations May 3, 2023
@igoroctaviano igoroctaviano changed the title v3: Auto Hydration of Segmentations [Feature Request] v3: Auto Hydration of Segmentations Jul 6, 2023
@james-hanks
Copy link

james-hanks commented Jul 14, 2023

@sedghi to add IDC branch containing @rodrigobasilio2022 fix

@fedorov
Copy link
Member

fedorov commented Jul 28, 2023

For the sake of background, here is an example in v2 that demonstrates how v2 handles a series that has 2 segmentation series: https://viewer.imaging.datacommons.cancer.gov/viewer/1.3.6.1.4.1.14519.5.2.1.7311.5101.170561193612723093192571245493. We are basically trying to get the functionality that proved to work very well in v2 for IDC and not only for IDC.

@igoroctaviano igoroctaviano changed the title [Feature Request] v3: Auto Hydration of Segmentations [Feature Request] Auto Hydration of Segmentations Aug 2, 2023
@igoroctaviano igoroctaviano changed the title [Feature Request] Auto Hydration of Segmentations [Feature Request] Auto load derived display sets when open series Aug 2, 2023
@igoroctaviano igoroctaviano changed the title [Feature Request] Auto load derived display sets when open series [Feature Request] Auto load derived display sets when opening series Aug 2, 2023
@rodrigobasilio2022
Copy link
Collaborator

The requirements in OHIF for this issue was approved and two PRs are open in IDC modes. @igoroctaviano will merge when all OHIF IDC PRs approved so far will be merged.

@james-hanks
Copy link

@rodrigobasilio2022 could you let us know if this is fixed on IDC's side and OHIF has anything to look into?

@rodrigobasilio2022
Copy link
Collaborator

This functionality is under review and works in IDC side, as a complement of modes

@igoroctaviano
Copy link
Contributor Author

@wayfarer3130 @sedghi do you guys think it would be useful to have a new property added to the hanging protocol to automatically load the latest derived display set for the active series? If so, I'll keep this ticket open and do that for the community. This is how v2 used to work, you didn't have to click on the SR and open the SR viewport. For now, we added this functionality only to the mode.

@wayfarer3130
Copy link
Contributor

I would suggest not loading the latest of any derived instances, but matching a display set instance, and taking the first item of the display set instance that matches. That way a hanging protocol can modify how the matching rules work for what to load. I'd also suggest doing that for segmentation data, but you might want to allow more than 1 matching rule for segmentation to succeed

@igoroctaviano
Copy link
Contributor Author

@wayfarer3130 @sedghi I'll close this issue for IDC purposes but I created another one for the better long term solution proposed by @wayfarer3130: #3879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority
Projects
Status: Done
Development

No branches or pull requests

7 participants