Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.4.0 #227

Merged
merged 41 commits into from
Feb 5, 2024
Merged

Release v3.4.0 #227

merged 41 commits into from
Feb 5, 2024

Conversation

ginberg
Copy link
Collaborator

@ginberg ginberg commented Feb 4, 2024

No description provided.

ginberg and others added 30 commits April 4, 2023 14:52
Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Merge branch 'develop' into cohortIds

# Conflicts:
#	R/CovariateData.R
#	R/GetCovariates.R
#	R/GetCovariatesFromCohortAttributes.R
#	R/GetDefaultCovariates.R
#	R/HelperFunctions.R
#	R/UnitTestHelperFunctions.R
#	extras/VignetteDataFetch.R
#	man/createEmptyCovariateData.Rd
#	tests/testthat/test-Aggregation.R
#	tests/testthat/test-CovariateData.R
#	tests/testthat/test-GetCovariates.R
#	tests/testthat/test-GetCovariatesTemporalSequence.R
#	tests/testthat/test-HelperFunctions.R
#	tests/testthat/test-Table1.R
#	tests/testthat/test-query-no-fail.R
#	tests/testthat/test-spot-checks.R
#	tests/testthat/test-tidyCovariates.R
#	vignettes/CreatingCovariatesUsingCohortAttributes.Rmd
#	vignettes/CreatingCustomCovariateBuilders.Rmd
#	vignettes/CreatingCustomCovariateBuildersKorean.Rmd
#	vignettes/UsingFeatureExtraction.Rmd
#	vignettes/UsingFeatureExtractionKorean.Rmd
…31013

Bump org.json:json from 20230227 to 20231013
Deprecate cohortId and use cohortIds
Merge branch 'develop' into unitTests

# Conflicts:
#	tests/testthat/test-GetCovariates.R
#	tests/testthat/test-GetCovariatesTemporalSequence.R
#	tests/testthat/test-HelperFunctions.R
#	tests/testthat/test-tidyCovariates.R
Modify unit tests structure
add analysis_name to covariateName to make it unique
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6a7e90a) 93.34% compared to head (cfb3962) 92.94%.

Files Patch % Lines
R/GetDefaultCovariates.R 28.57% 5 Missing ⚠️
R/CovariateData.R 85.71% 3 Missing ⚠️
R/GetCovariatesFromOtherCohorts.R 60.00% 2 Missing ⚠️
R/HelperFunctions.R 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   93.34%   92.94%   -0.40%     
==========================================
  Files          16       16              
  Lines        1412     1417       +5     
==========================================
- Hits         1318     1317       -1     
- Misses         94      100       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ginberg ginberg merged commit 8a7cb70 into main Feb 5, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant