-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.4.0 #227
Merged
Release v3.4.0 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Merge branch 'develop' into cohortIds # Conflicts: # R/CovariateData.R # R/GetCovariates.R # R/GetCovariatesFromCohortAttributes.R # R/GetDefaultCovariates.R # R/HelperFunctions.R # R/UnitTestHelperFunctions.R # extras/VignetteDataFetch.R # man/createEmptyCovariateData.Rd # tests/testthat/test-Aggregation.R # tests/testthat/test-CovariateData.R # tests/testthat/test-GetCovariates.R # tests/testthat/test-GetCovariatesTemporalSequence.R # tests/testthat/test-HelperFunctions.R # tests/testthat/test-Table1.R # tests/testthat/test-query-no-fail.R # tests/testthat/test-spot-checks.R # tests/testthat/test-tidyCovariates.R # vignettes/CreatingCovariatesUsingCohortAttributes.Rmd # vignettes/CreatingCustomCovariateBuilders.Rmd # vignettes/CreatingCustomCovariateBuildersKorean.Rmd # vignettes/UsingFeatureExtraction.Rmd # vignettes/UsingFeatureExtractionKorean.Rmd
fix notes
…31013 Bump org.json:json from 20230227 to 20231013
fix note
Deprecate cohortId and use cohortIds
Merge branch 'develop' into unitTests # Conflicts: # tests/testthat/test-GetCovariates.R # tests/testthat/test-GetCovariatesTemporalSequence.R # tests/testthat/test-HelperFunctions.R # tests/testthat/test-tidyCovariates.R
Modify unit tests structure
add analysis_name to covariateName to make it unique
sd calculation fix
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 93.34% 92.94% -0.40%
==========================================
Files 16 16
Lines 1412 1417 +5
==========================================
- Hits 1318 1317 -1
- Misses 94 100 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.