Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd calculation fix #224

Merged
merged 1 commit into from
Jan 24, 2024
Merged

sd calculation fix #224

merged 1 commit into from
Jan 24, 2024

Conversation

ginberg
Copy link
Collaborator

@ginberg ginberg commented Jan 23, 2024

see #223

@ginberg ginberg requested a review from anthonysena January 23, 2024 13:10
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c90b392) 92.94% compared to head (e568101) 92.94%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #224   +/-   ##
========================================
  Coverage    92.94%   92.94%           
========================================
  Files           16       16           
  Lines         1417     1417           
========================================
  Hits          1317     1317           
  Misses         100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@anthonysena anthonysena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my review - thanks for making this update!

@ginberg ginberg merged commit 7c1a414 into develop Jan 24, 2024
10 checks passed
@anthonysena anthonysena linked an issue Feb 2, 2024 that may be closed by this pull request
@anthonysena anthonysena deleted the sdm branch April 22, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDM calculation fix
2 participants