Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] Add shopfloor barcode app #25

Merged
merged 1,045 commits into from
Nov 3, 2020
Merged

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Apr 28, 2020

@simahawk simahawk added this to the 13.0 milestone Apr 28, 2020
@simahawk
Copy link
Contributor Author

I've canceled the build as it's useless to run it now.

sebalix pushed a commit to sebalix/wms that referenced this pull request Jun 4, 2020
@ritco
Copy link

ritco commented Aug 4, 2020

@simahawk is there still a plan to create a scan app?

@simahawk
Copy link
Contributor Author

simahawk commented Aug 4, 2020

@ritco the app is here, in this PR actually. The behavior is the on described in the specs linked above.
For now we are in heavy testing / fixing phase. It will be deployed on production very soon.

sebalix and others added 23 commits August 10, 2020 12:44
single_pack_transfer ATM works only with package levels.
If you use it w/ picking types that do not move entire packages
you'll get bad results.

The long term is to do it as in location_content_transfer
which works w/ both move lines and pkg levels.
When moving away from a process the global state key was not updated.
Hence, all the events emitted right after where using a wrong prefix.
Now the router wipes the state when needed.
Additionally, the prefix now includes the process name
so that its events are completely encapsulated by their usage.
By design the endpoint should be called 'unload_scan_destination'
but it has been named 'unload_set_destination'.
Writing on pkg_level.is_done w/out checking if already set
is going to sum up the whole qty as done each time.
Hence a pkg level w/ 100 units done, if scanned 5 times, will have 500 done.
Single pack transfer fix/refactor + misc fixes
Add a packing information field on partner that will be displayed on the
stock.picking form when the picking type requires it
Unable to compare `False` and strings.
simahawk and others added 15 commits October 29, 2020 09:14
zone_picking/unload_set_destination: fix move.state = partially_available handling
Pickings are editable even for not outgoing type.
Most of the times operators change carrier during checkout.
When move lines have no package level (e.g. we use the "Open Package"
button), they still have the package in "package_id".
Users should be able to scan this package to identify that they
want to take the products from there (they may have no label on
products).
Shopfloor mobile: improve translations
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: All good. Thanks you for this amazing work

@jgrandguillaume
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-25-by-jgrandguillaume-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 3, 2020
Signed-off-by jgrandguillaume
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-25-by-jgrandguillaume-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1b9c46b into OCA:13.0 Nov 3, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9d18406. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants