-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0] Add shopfloor barcode app #25
Conversation
I've canceled the build as it's useless to run it now. |
Misc UI fixes/imp
@simahawk is there still a plan to create a scan app? |
@ritco the app is here, in this PR actually. The behavior is the on described in the specs linked above. |
checkout: fix packaging field to use
single_pack_transfer ATM works only with package levels. If you use it w/ picking types that do not move entire packages you'll get bad results. The long term is to do it as in location_content_transfer which works w/ both move lines and pkg levels.
When moving away from a process the global state key was not updated. Hence, all the events emitted right after where using a wrong prefix. Now the router wipes the state when needed. Additionally, the prefix now includes the process name so that its events are completely encapsulated by their usage.
By design the endpoint should be called 'unload_scan_destination' but it has been named 'unload_set_destination'.
Writing on pkg_level.is_done w/out checking if already set is going to sum up the whole qty as done each time. Hence a pkg level w/ 100 units done, if scanned 5 times, will have 500 done.
Single pack transfer fix/refactor + misc fixes
Add a packing information field on partner that will be displayed on the stock.picking form when the picking type requires it
Unable to compare `False` and strings.
Shopfloor misc imp/fix
zone_picking/unload_set_destination: fix move.state = partially_available handling
Pickings are editable even for not outgoing type. Most of the times operators change carrier during checkout.
When move lines have no package level (e.g. we use the "Open Package" button), they still have the package in "package_id". Users should be able to scan this package to identify that they want to take the products from there (they may have no label on products).
shopfloor: fix singleton error
Shopfloor mobile: improve translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review: All good. Thanks you for this amazing work
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
It looks like something changed on |
Congratulations, your PR was merged at 9d18406. Thanks a lot for contributing to OCA. ❤️ |
Specs are still here: https://docs.google.com/presentation/d/1A5TVJXryqod7IwVIl03mDUJIUGzqJ-T2FzSWA90zAvw/edit#slide=id.p