zone_picking/unload_set_destination: fix move.state = partially_available handling #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
force-pushed
the
zone-picking-fix-partially-avail
branch
from
d6aa35b to
f62c07d
Compare
Codecov Report
@@ Coverage Diff @@
## 13.0-shopfloor #96 +/- ##
===============================================
Coverage 90.56% 90.57%
===============================================
Files 92 92
Lines 5153 5158 +5
===============================================
+ Hits 4667 4672 +5
Misses 486 486
Continue to review full report at Codecov.
|
sebalix
reviewed
Oct 21, 2020
| qty_to_split = sum(other_move_lines.mapped("product_uom_qty")) | ||
| if other_move_lines or self.state == "partially_available": | ||
| if intersection: | ||
| # TODO @sebalix: please check if we can abandon the flag. |
There was a problem hiding this comment.
Ok I see, indeed better to do the "set operation" outside of this method. Can't see a side-effect by doing so.
|
@sebalix this one could be merged as long as we have TODO items and we can get back later to them |
sebalix
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: 1699