[FIX] web_chatter_position: Fixes bug where incompatible apps crash #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatter position bottom would crash.
|
Apparently duplicate of #2571 as it fixes the same issue. Leaving it open because I think this one should be merged instead. May be closed otherwise. |
|
#2571 was merged so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some (new) apps, the query selector
querySelector('.o_form_sheet_bg')inweb_chatter_positionwill not return anything. This causes a crash when you try to open the app in question.You can replicate this by installing both the new 'Knowledge' app, as well as
web_chatter_position, and trying to open the former when the current user's preferences have been set to chatter position 'bottom'.Odoo avoids this problem by exiting early without a chatter if there no
sheet-bg. This PR implements the exact same solution. See the Odoo source here.