Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [FIX] web_chatter_position: fixes JS assuming "o_form_sheet_bg" is always found #2571

Merged
merged 1 commit into from
Aug 24, 2023
Merged

[16.0] [FIX] web_chatter_position: fixes JS assuming "o_form_sheet_bg" is always found #2571

merged 1 commit into from
Aug 24, 2023

Conversation

BT-jmontero
Copy link
Contributor

@BT-jmontero BT-jmontero commented Jul 24, 2023 •
edited
Loading

Fixes the issue reported here: #2464

@BT-jmontero BT-jmontero changed the title Fixed JS assuming "o_form_sheet_bg" is always found [16.0] [FIX] Fixed JS assuming "o_form_sheet_bg" is always found Jul 25, 2023
@BT-jmontero BT-jmontero mentioned this pull request Jul 25, 2023
Open
@BT-jmontero BT-jmontero changed the title [16.0] [FIX] Fixed JS assuming "o_form_sheet_bg" is always found [16.0] [FIX] web_chatter_position: fixes JS assuming "o_form_sheet_bg" is always found Jul 25, 2023
BT-anieto
BT-anieto reviewed Jul 25, 2023
View reviewed changes
Copy link

@BT-anieto BT-anieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I added a suggestion in case you want to consider it.

web_chatter_position/static/src/js/web_chatter_position.esm.js Outdated Show resolved Hide resolved
@BT-jmontero
Copy link
Contributor Author

@JuMiSanAr @ivantodorovich As contributors of web_chat_positions, maybe you can review this PR fixing a small issue ;) Thanks in advance for your time!!

ivantodorovich
ivantodorovich approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree w/ the suggestion :) pre-approving

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Florian-Laport Florian-Laport mentioned this pull request Aug 21, 2023
Closed
@BT-jmontero
Copy link
Contributor Author

Hola @yajo, this module has no maintainer. Could please merge this PR? Thanks in advance for your support!!

@yajo
Copy link
Member

yajo commented Aug 24, 2023

You can volunteer to become a maintainer if you want 😉

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2571-by-yajo-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6877ff2 into OCA:16.0 Aug 24, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7c898bf. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@BT-anieto BT-anieto BT-anieto approved these changes

@JuMiSanAr JuMiSanAr JuMiSanAr approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BT-jmontero @OCA-git-bot @yajo @ivantodorovich @BT-anieto @JuMiSanAr