-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] stock_inventory: create missing quants if needed #2058
base: 16.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Code review.
def _compute_virtual_in_progress_inventory_id(self): | ||
Inventory = self.env["stock.inventory"] | ||
for rec in self: | ||
rec.virtual_in_progress_inventory_id = Inventory.search( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer a search outside the loop and then filtered_domain on locations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ea1ba34
to
9c57527
Compare
ee5aede
to
037988e
Compare
0f7e1d6
to
b393997
Compare
…y configuration to avoid having no smartbutton on the adjustment form
… new quants during the inventory
b393997
to
48178b1
Compare
ping @DavidJForgeFlow @LoisRForgeFlow just a gently reminder -> #1935 (comment) |
Hi @benwillig Thanks for the reminder and thanks for adding the optional stetting to enable that, when you do have a lot of bin locations and many products, creating all the quants for every inventory can become a little crazy, but I understand that in some situations is usefull. Could you fix the conflicts that prevent merging? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Based on #2017
cc @DavidJForgeFlow @rousseldenis