-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] sentry: migrate sentry-raven to new api sentry-sdk #2254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review.
thanks for porting this must-have update.
"Odoo Community Association (OCA)", | ||
"Odoo Community Association (OCA)," | ||
"Vauxoo", | ||
"maintainers": ["barsi", "naglis", "versada", "moylop260", "fernandahf"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are no rules regarding maintainers quantity, but maybe 5 maintainers is a little too much ?
CC : @OCA/community-maintainers
Thanks for the partial review. I added some more fixes as explained in commits, most notably I added one more wsgi patch because as it is the |
I reviewed the module and it seems to be working fine. Nice information and no longer depending on the raven module! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using it in production since weeks
LGTM
Can you please rebase ? |
@legalsylvain @paradoxxxzero can we move this forward? This should also be ported to v13 and v15. can I help in any way? |
using the traces_sample_rate can context be added to the transaction to reproduce the slow responses? for instance a use case is if you have known long running calls, like to a shipping api, would like to filter the results to call not made with that certain action. Error traces have all the data. the performance samples do not. POST /web/dataset/call_button would this be a good place to have an option like inherit_id="web.assets_backend"
|
+1, what needs to be done on this to get it merged ? |
We need a green TravisCI build. That's blocking this right now. |
14f83bf
to
c01547c
Compare
Because post_load is called after odoo.service.server start It has already registered the unpatched odoo.service.wsgi_server.application So patch it here too. This enables wsgi performance reporting with sentry_traces_sample_rate
c01547c
to
4c413fa
Compare
Can we merge ? |
@paradoxxxzero do you have any idea how to get the header set? there are a number of integration examples now. But not clear to me the best approach here. https://develop.sentry.dev/sdk/performance/#header-sentry-trace |
@schiggi @dnplkndll @thapakazi Can you please mark your review status on this PR ? |
This PR has the |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 4917899. Thanks a lot for contributing to OCA. ❤️ |
This is a migration done by cherry-picking #1942 on top of current 14.0.
This superseeds #2223