Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [IMP] sentry: Switch from raven to sentry_sdk #2223

Closed
wants to merge 1 commit into from

Conversation

dnplkndll
Copy link

No description provided.

@dnplkndll dnplkndll changed the title [IMP] sentry: Switch from raven to sentry_sdk [14.0] [IMP] sentry: Switch from raven to sentry_sdk Dec 4, 2021
@dnplkndll dnplkndll marked this pull request as draft December 4, 2021 20:03
@dnplkndll dnplkndll force-pushed the sentry_sdk_abc branch 2 times, most recently from 632cd5a to 556ef89 Compare December 4, 2021 20:29
@dnplkndll dnplkndll mentioned this pull request Dec 4, 2021
@dnplkndll dnplkndll marked this pull request as ready for review December 4, 2021 21:22
@dnplkndll
Copy link
Author

to implement the odoo_dir sha fetch and pass as release without a tag need to pick

https://forum.sentry.io/t/fetch-git-sha-equivalent-in-the-unified-python-sdk/5521

raven.fetch_git_sha(odoo_dir)

@dnplkndll
Copy link
Author

to implement the odoo_dir sha fetch and pass as release without a tag need to pick

https://forum.sentry.io/t/fetch-git-sha-equivalent-in-the-unified-python-sdk/5521

raven.fetch_git_sha(odoo_dir)

oh nevermind https://github.com/OCA/server-tools/pull/2223/files#diff-297136b7cbfb1c11044f0db7d8fa3da6b2f9a50b6dcb046f94f12068b7ae7468R76

so I think this is covering fine after debug.

I actually don't pass in any .git refs in my docker build if anyone else can test that. I am not sure how you get the .git in. maybe on a local non docker setup?

@legalsylvain
Copy link
Contributor

12.0 version still uses new sentry_sdk lib.
https://github.com/OCA/server-tools/blob/12.0/sentry/__manifest__.py#L20
The work has been
That in Nov 2020. #1942
Could you better cherry peak that commit, and then apply extra changes, if required.

And the migration on January 2021 (from 13.0) to 14.0 doesn't take into account that change. #1997 cc : @moylop260

@dnplkndll
Copy link
Author

I see CI fail, redis package needs added to support that or removed. I was going to remove as I do not find the metadata useful. But in general not sure how may installs would have redis sessions and otherwise would not be a useful requirement to always have.

redis
GET 'session:9ffae8e961b33e78db9ee7fdb540fe2ba25fea80'
redis.key: session:9ffae8e961b33e78db9ee7fdb540fe2ba25fea80
redis.command: GET
info
15:19:27

image

@stanevicius1
Copy link

Can you make pull request with fixes?

@thomaspaulb
Copy link
Contributor

Closing, since already handled by #2254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants