Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] [FIX] purchase_requisition_bid_selection - cancel draftbid on generate po #93

Merged
merged 3 commits into from
Feb 6, 2015
Merged

[8.0] [FIX] purchase_requisition_bid_selection - cancel draftbid on generate po #93

merged 3 commits into from
Feb 6, 2015

Conversation

yvaucher
Copy link
Member

@yvaucher yvaucher commented Feb 5, 2015

Fix cancellation of draftpo remaing in state draftpo instead of being cancelled when generating PO.
Plus add test to reproduce

This PR depends on

@yvaucher yvaucher changed the title [8.0][FIX] cancel draftbid on generate po [8.0] [FIX] purchase_requisition_bid_selection - cancel draftbid on generate po Feb 5, 2015
@pedrobaeza
Copy link
Member

👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.71%) to 72.77% when pulling 52bcc31 on yvaucher:8.0-fix-cancel-draftbid-on-generate_po into dfd7391 on OCA:8.0.

lepistone
lepistone reviewed Feb 6, 2015
View reviewed changes
purchase_requisition_bid_selection/tests/test_generate_po.py


class test_generate_po(common.TransactionCase):
""" Test genertation of a purchase order from selected Bid and ensure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/genertation/generation

@lepistone
Copy link
Member

👍, and thanks for the cool workflow stubbing - it's not what we want to test here.

@yvaucher yvaucher force-pushed the 8.0-fix-cancel-draftbid-on-generate_po branch from 52bcc31 to d9d5bb4 Compare February 6, 2015 10:40
@yvaucher
Copy link
Member Author

yvaucher commented Feb 6, 2015

@lepistone I amended fixes in last commit

@max3903
Copy link
Member

max3903 commented Feb 6, 2015

👍

max3903 pushed a commit that referenced this pull request Feb 6, 2015
Merge pull request #93 from yvaucher/8.0-fix-cancel-draftbid-on-gener…
df69a2f 
…ate_po

[8.0] [FIX] purchase_requisition_bid_selection - cancel draftbid on generate po
@max3903 max3903 merged commit df69a2f into OCA:8.0 Feb 6, 2015
@yvaucher yvaucher deleted the 8.0-fix-cancel-draftbid-on-generate_po branch February 7, 2015 19:38
dnplkndll pushed a commit to Kencove/purchase-workflow that referenced this pull request Feb 24, 2021
@max3903
[FIX] Product categories (Issue OCA#93)
66e3486
dnplkndll pushed a commit to Kencove/purchase-workflow that referenced this pull request Feb 24, 2021
@max3903
Merge branch 'max-fixes' into 'develop'
7d2159c 
[FIX] Various issues

Closes OCA#107, OCA#106, OCA#104, OCA#77, OCA#102, OCA#94, OCA#93, OCA#92, OCA#89, OCA#88, OCA#86, OCA#80, OCA#78, OCA#61, OCA#60, and OCA#8

See merge request kencove/odoo/odoo-platform!70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yvaucher @pedrobaeza @coveralls @lepistone @max3903