[ADD] [7.0] Add module 'purchase_invoice_control_check'. #89
Conversation
JordiBForgeFlow
changed the title
|
I would call it purchase_service, because the rule is to put singular forms, and there are several features, not only the cancel one. Also, a better place for this is the project-service repository I think. |
|
@pedrobaeza I renamed to 'purchase_services_check' in a later commit, but agree to change to 'purchase_service_check' or 'purchase_service'. My understanding is that 'project-service' repo is to be used for service or project oriented companies. |
|
It is not desirable for the |
|
OK, @dreispt and @jbeficent. We continue here with the review with the new name. |
JordiBForgeFlow
changed the title
|
Renamed to 'purchase_invoice_control_service', using singular forms. I think that the new name describes more precisely what it does. |
|
If you rename it that way, I prefer then purchase_invoice_control_check, because it also includes the check for non existing product_id |
|
Done. I also reworded the module description. |
JordiBForgeFlow
changed the title
| def wkf_confirm_order(self, cr, uid, ids, context=None): | ||
| for order in self.browse(cr, uid, ids, context=context): | ||
| if order.invoice_method == 'picking': | ||
| for order_line in order.order_line: |
There was a problem hiding this comment.
Why not if order.has_services()?
|
@odony and @jco-odoo are proposing to submit a PR to the Odoo core. Would you agree @pedrobaeza? Then maybe there's no need for this PR. |
|
Yeah, this is indeed a patch for something that must be on the core. |
…cing [ADD] module sale_owner_stock_sourcing
Currently a user can create a PO containing services and set the invoice control 'Based on incoming shipments', and the application does not prevent the user from doing that.
Then, the user has no option in the 'Invoice Control' menu to invoice that line, and can only invoice based on a list of PO lines.
This modules introduces the following features:
Prevents a user from being able to confirm a Purchase Order with invoice control 'Based on incoming shipments' that contains services.
Makes it possible to cancel a Purchase Order in which the user created the PO containing services, with invoice control 'Based on incoming shipments' (in order to correct the PO's that were created incorrectly before this module was used).