Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] purchase_triple_discount: Migration to 11.0 #732

Merged
merged 5 commits into from
Aug 7, 2019

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Aug 5, 2019

superseeds these abandoned PRs: #595 and #611

  • Integrate with supplierinfo_dicount
  • readme parts

cc @Tecnativa

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CIs go well

Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review
LGTM
👍

@pedrobaeza
Copy link
Member

We are going to add the purchase.supplierinfo stuff here as well, so setting WIP.

@chienandalu chienandalu force-pushed the 11.0-mig-purchase_triple_discount branch from 2ac3450 to 82b7883 Compare August 5, 2019 11:20
@chienandalu
Copy link
Member Author

Changes done to integrate with purchase.supplierinfo

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra tests on new features.

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise Code Review LGTM 👍

@legalsylvain
Copy link
Contributor

Thanks a lot @chienandalu.

@legalsylvain
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 11.0-ocabot-merge-pr-732-by-legalsylvain-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7c9cede. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

@OCA-git-bot OCA-git-bot merged commit 82b7883 into OCA:11.0 Aug 7, 2019
OCA-git-bot added a commit that referenced this pull request Aug 7, 2019
Signed-off-by legalsylvain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants