-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][11.0] purchase_triple_discount Migrated. #611
Conversation
Hey @krunal267, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Please check CLA and CIs status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve Code
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
{ | ||
'name': 'Purchase Triple Discount', | ||
'version': '11.0.0.0.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version:'11.0.1.0.0'
cls.partner = cls.env['res.partner'].create({ | ||
'name': 'Mr. Odoo', | ||
}) | ||
cls.product1 = cls.env['product.product'].create({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here cls.env['product.product']
and other objects use multiple time, IMO here use like a global variable.
@pedrobaeza there is other PR for the migration of this module #595 |
Hello @krunal267 , thanks for this contribution. It's 6 month since this PR withouy answering, are you going to continue or if not can we close it? Thanks in advance! |
Hello @krunal267 , thanks for this contribution. It's 6 month since this PR withouy answering, are you going to continue or if not can we close it? Thanks in advance! |
Superseeded by #732 |
Purchase Triple Discount
Manage triple discount on purchase order lines.