Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][11.0] purchase_triple_discount Migrated. #611

Closed
wants to merge 8 commits into from
Closed

[MIG][11.0] purchase_triple_discount Migrated. #611

wants to merge 8 commits into from

Conversation

krunal267
Copy link

Purchase Triple Discount

Manage triple discount on purchase order lines.

@oca-clabot
Copy link

Hey @krunal267, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 11.0 milestone Nov 24, 2018
@pedrobaeza pedrobaeza mentioned this pull request Nov 24, 2018
54 tasks
@pedrobaeza
Copy link
Member

Please check CLA and CIs status

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
{
'name': 'Purchase Triple Discount',
'version': '11.0.0.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version:'11.0.1.0.0'

cls.partner = cls.env['res.partner'].create({
'name': 'Mr. Odoo',
})
cls.product1 = cls.env['product.product'].create({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here cls.env['product.product'] and other objects use multiple time, IMO here use like a global variable.

@emagdalenaC2i
Copy link

@pedrobaeza there is other PR for the migration of this module #595

@pedrobaeza
Copy link
Member

Both PRs (#595 and #611) are in red state, so no good choice for now.

@rafaelbn
Copy link
Member

Hello @krunal267 , thanks for this contribution.

It's 6 month since this PR withouy answering, are you going to continue or if not can we close it?

Thanks in advance!

@rafaelbn
Copy link
Member

Hello @krunal267 , thanks for this contribution.

It's 6 month since this PR withouy answering, are you going to continue or if not can we close it?

Thanks in advance!

@pedrobaeza
Copy link
Member

Superseeded by #732

@pedrobaeza pedrobaeza closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants