14.0 mig website product configurator #12
Conversation
PCatinean
force-pushed
the
14.0-mig-website_product_configurator
branch
from
9ade319 to
6cb8250
Compare
|
Hello @PCatinean Are you planning to continue work on this? |
|
Hi Daniel, yes quite a few things are fixed in this PR we just have to revert all changes which undo your works and also have pre-commit checks pass. @pledrateam can you please look into this? |
|
@PCatinean the changes we did were to have pre-commits pass, so reverting them works against your goal. |
|
@dreispt we're working on it |
|
Shouldn't this also bring the full history? |
* [FIX] Updated js tests with new price format and VAT inclusive
[IMP] Updated modules description and icons for appstore and apps menu
… and image update
* Flake8 fixes
Completes the following TODOs: * Refactor so multiple values can be checked at once also a better method for building the domain using the logical operators is required * Enable the usage of OR operators between domain lines Adds the following TODOs: * Enable the usage of OR operators between implied_ids * Add implied_ids sequence field to enforce order of operations
…ant to get_variant
…igurator_mrp : correct method-name, claas-name, arguments
…, replace request.website.render with request.render
…t and error while reconfigure product
Fix hasClass('.cfg-radio') -> With the DOT, the class is never founded
Use getAttribute("name") instead of attribute[0].name because it crash with radio-button div
…add 404 from website.
|
@pledrateam codecoverage is failing |
|
Test have passed with coverage increase, can you please review @dreispt @CasVissers-360ERP ? |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c728b81. Thanks a lot for contributing to OCA. ❤️ |
No description provided.