Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 14.0 #2

Closed
8 of 10 tasks
dreispt opened this issue Mar 25, 2021 · 14 comments
Closed
8 of 10 tasks

Migration to version 14.0 #2

dreispt opened this issue Mar 25, 2021 · 14 comments
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@dreispt
Copy link
Member

dreispt commented Mar 25, 2021

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

Modules to migrate

@dreispt
Copy link
Member Author

dreispt commented Mar 25, 2021

cc @Chandresh-OSI

@PCatinean
Copy link
Contributor

@dreispt we had previous migration work with multiple other fixes included. We did not know if we could pick them up due to high workload but now we had a chance to get back to it. I think our current PR superseeds the existing one. Can we change assignment to https://github.com/pledrateam ?

For the record tha plan is to have a PR with migration of the current state and then start refactoring different sections for which I have created issues.

@dreispt
Copy link
Member Author

dreispt commented Apr 22, 2021

@PCatinean It would have been nice to have shared existing work when we mentioned we wanted to work on the v14 migration.
We have been working on this for two weeks, and I understand we are to throw away all this work.

I'm happy to let you lead on this.
Just let me know exactly what you want to do next.
You might want to consider reusing and building on top or our PR #1.

Thanks

@PCatinean
Copy link
Contributor

As said we had previous effort that was stopped even before we took the decision to move to OCA but ok we will try to rebase on the existing PR.

@dreispt
Copy link
Member Author

dreispt commented Apr 22, 2021

OK, we are stopping all work and waiting for your PRs.

@dreispt
Copy link
Member Author

dreispt commented Apr 27, 2021

@PCatinean I see no PR form you, so I believe you're yet to start work.
I have delivery dates to meet, so I must move on.
I'm sure fixes and refactoring will be needed, but #1 is now has a green build, so I moved on and merged it.

@Chandresh-OSI Please proceed with work on #3

@PCatinean
Copy link
Contributor

I am not sure why you would assume I have not even started anything Daniel when I mentioned we already have work pending. I have not opened until now because of some delays and my vacation started as well. Regardless you can go ahead and do your thing no problem.

@dreispt
Copy link
Member Author

dreispt commented Apr 28, 2021

@PCatinean Show me the code. I don't see any PRs here.

By the way, there was non trivial work done to get a TravisCI build, including breaking big methods into smaller ones, to get through the "too complex" check fails. So I think it will save you dozens of hours starting the existing migration code.

Can you please open your WIP PRs so we can collaborate and know what each is working on?

@bizzappdev
Copy link
Contributor

website_product_configurator #12

@bizzappdev
Copy link
Contributor

website_product_configurator #12 @pledrateam is working on it

@pledrateam
Copy link
Contributor

product_configurator_stock #29

@pledrateam
Copy link
Contributor

pledrateam commented May 25, 2021

product_configurator_purchase #31

@pledrateam
Copy link
Contributor

website_product_configurator_mrp #32

@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 30, 2022
@github-actions github-actions bot closed this as completed Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

4 participants