Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] pos_order_to_sale_order: Migration to 14.0 #976

Merged
merged 40 commits into from
May 5, 2023

Conversation

zamberjo
Copy link
Member

No description provided.

legalsylvain and others added 30 commits April 3, 2023 09:39
* [ADD] new module pos_order_to_sale_order
…ion of this module (price unit loss, and pricelist) if pos_pricelist is installed
[FIX] Remove console.log ;
[IMP] Do not import js files in backend
[IMP] apply new readme structure
[FIX] remove useless demo file
[FIX] some pylint issues
[REF] add maintainers and developpment status
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-8.0/pos-8.0-pos_order_to_sale_order
Translate-URL: https://translation.odoo-community.org/projects/pos-8-0/pos-8-0-pos_order_to_sale_order/
Co-authored-by: Iván Todorovich <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_order_to_sale_order
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/
Currently translated at 100.0% (23 of 23 strings)

Translation: pos-12.0/pos-12.0-pos_order_to_sale_order
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/es/
Currently translated at 100.0% (23 of 23 strings)

Translation: pos-12.0/pos-12.0-pos_order_to_sale_order
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/pt_BR/
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
…) is null, that occures if pos_restaurant is installed
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_order_to_sale_order
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_order_to_sale_order
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/
@zamberjo zamberjo mentioned this pull request Apr 19, 2023
16 tasks
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @zamberjo 👍

A tiny functional issue I found is that when you convert the pos order to sale order it isn't flushed from the PoS order list, so they remain there until manually removed. May you have to destroy it.

@chienandalu
Copy link
Member

/ocabot migration pos_order_to_sale_order

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Apr 19, 2023
@belenaures
Copy link

Tested and found that everything works correctly. It is true that as for the orders created (as [chienandalu] says), could be deleted from the PoS order list once they have been created.

@zamberjo
Copy link
Member Author

hi @chienandalu @belenaures done, now the order is removed from the list once the sale.order is created

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@chienandalu
Copy link
Member

@belenaures add a proper Github approval

Copy link

@belenaures belenaures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zamberjo
Copy link
Member Author

zamberjo commented May 5, 2023

Hi @pedrobaeza Can you check it?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-976-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ab8e81b into OCA:14.0 May 5, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4f37a34. Thanks a lot for contributing to OCA. ❤️

@zamberjo zamberjo deleted the 14.0-mig-pos_order_to_sale_order branch May 7, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.