add pos_sale_order module

[chafique-delli]

This module allows to create a sale order instead of a pos order in POS

[legalsylvain]

Hi Chafique,

• could you update the .travis file, to include reference to there OCA repositories where we can find the extra modules : https://github.com/OCA/pos/pull/35/files#diff-d53fea56debd4209ae3423d30e57fac5R30);
• You have a minor pylint error : https://travis-ci.org/OCA/pos/jobs/68836445#L170;

Thanks.

[legalsylvain]

I guess obsolete commented lines are not necessary.

[chafique-delli]

@legalsylvain, Thanks, Sylvain for your comments.I changed as you suggested me.

[sebastienbeau]

This field is not visible on the POS view. You must add it if we want to configure it correctly

[legalsylvain]

Hi @chafique-delli. you have to change the travis file, adding one line per extra-repositories your module need. doing that you'll fix Runbot / Travis Error.

[sebastienbeau]

This is not demo data but configuration data. Please rename the directory "demo" in "data" to avoid confusion. Thanks

[legalsylvain]

in fact, it is now demo data. See my previous comment.

[legalsylvain]

Waiting for 2 Merges :

1/ sale_quick_payment : you referenced an akretion branch, and OCA branch can not depend on custom branch.
There is another PR about porting this module : OCA/e-commerce#46
Could you check it ?

2/ account_bank_statement_sale_order : OCA/account-reconcile#114

[houssine78]

Hi @chafique-delli , @legalsylvain , @sebastienbeau

the referenced PR has been resubmited by this one OCA/e-commerce#54

and it seems that the concerned module have been moved to sale_workflow with this PR OCA/e-commerce#54 by the way, this PR needs some love if you could get a quick view ;)

I think that the travis file should be updated accordingly

[yelizariev]

@chafique-delli if it's possible, I suggest to rename the module, because there is already one with the same name https://apps.odoo.com/apps/modules/8.0/pos_sale_order/

[chafique-delli]

@yelizariev, your module is not OCA module so I do not see why I have to change the name of my OCA module.

[yelizariev]

@chafique-delli of course you don't have to do it.
Just note, that your (OCA) module will not be available on app store, because name is already used. If someone installs module via app-store (built-in odoo feature), he will not be able to do it this way.

[rafaelbn]

Hi @OCA/pos-maintainers do you think we must change module names as commented #35 (comment) and #35 (comment) ?

Please @chafique-delli could you review this PR, let go ahead with it. Thanks!

[bealdav]

@yelizariev Did your module have the same features than this one ?

[yelizariev]

@bealdav my module provides completely different feature: create pos order from existed sale order

[StefanRijnhart]

Just to let you know, I have picked up this branch and am working on a roundtrip to create sale orders as well as load them back into pos here: https://github.com/stefanrijnhart/pos/tree/8.0-pos-sale-order. The roundtrip is currently there, but it still needs work with regards to pos configuration, sale order confirmation and sale order payments.

[legalsylvain]

Closing this PR due to long inactivity