Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 sale quick payment #54

Closed
wants to merge 6 commits into from

Conversation

gurneyalex
Copy link
Member

port sale_quick_payment to v8

@gurneyalex
Copy link
Member Author

updated version of #46

@gurneyalex gurneyalex force-pushed the 8.0-sale_quick_payment branch 2 times, most recently from 533cc71 to 010940f Compare September 3, 2015 09:56
@guewen
Copy link
Member

guewen commented Sep 3, 2015

Since there is a button to display the payments (https://github.com/gurneyalex/e-commerce/blob/8.0-sale_quick_payment/sale_payment_method/sale_view.xml#L19-L23) I think we could remove the payment_ids field from the sales orders' view.

@bguillot
Copy link

bguillot commented Sep 3, 2015

Thanks this module is needed ! 👍

@guewen
Copy link
Member

guewen commented Sep 3, 2015

👍

@rafaelbn
Copy link
Member

rafaelbn commented Sep 3, 2015

Hi @gurneyalex:

  • In order yo have same place for everything, don't you think is better yo have a tab in sales order for payments as in invoices?

After trying to test this module I have doubts sorry...

  • this is a module for e-commerce and this module install sale_payment_method
  • In e-commerce usually payment are done throug Paypal, Ogone, Stripe, Credit Card, ...
  • This module sale_quick_payment I guess helps to sale online and receive the payment in the sale order

Why is not related with how the customer paid (payment.acquirer)?

When customer buy online you would like to have their purchases "quick paid" when the payment is done through the payment.acquirer. How you make this with this module?

Thanks

@gurneyalex gurneyalex force-pushed the 8.0-sale_quick_payment branch from 7aee15d to e1540c9 Compare September 4, 2015 07:36
this information is available via a button added by sale_payment_method
@gurneyalex gurneyalex force-pushed the 8.0-sale_quick_payment branch from e1540c9 to 88fc257 Compare September 4, 2015 07:37
@guewen
Copy link
Member

guewen commented Sep 4, 2015

this is a module for e-commerce and this module install sale_payment_method
In e-commerce usually payment are done throug Paypal, Ogone, Stripe, Credit Card, ...
This module sale_quick_payment I guess helps to sale online and receive the payment in the sale order

Hi @rafaelbn,

This set of modules (sale_payment_method, sale_automatic_workflow, ...) has never been thought in the context of the Odoo e-commerce modules (website_sale, ...).
These modules are used by the Magento, Prestashop (etc.) connectors when you don't necessary have the website modules installed.
Possibly an integration with the payment.acquirer would be possible, but I'm not sure about that. Anyway I don't think it could happen in 8.0 because the sale_payment_method module is already widely used.

@guewen
Copy link
Member

guewen commented Sep 4, 2015

@rafaelbn I think this project brings confusion because it mixes addons related to odoo's e-commerce and to e-commerce addons unrelated to it and both not always share the same path.

@pedrobaeza
Copy link
Member

That's why we talked about moving this kind of modules to sale-workflow.

@guewen
Copy link
Member

guewen commented Sep 4, 2015

That's why we talked about moving this kind of modules to sale-workflow.

totally!

@gurneyalex
Copy link
Member Author

So this would be

  • sale_quick_payment
  • sale_sale_payment_method

Do we want to also move

  • sale_automatic_workflow
  • sale_payment_method_automatic_workflow ?

@pedrobaeza
Copy link
Member

Yeah, I think so, please see #47

@LeartS
Copy link

LeartS commented Sep 4, 2015

I agree. e-commerce is going to be a big part of Odoo with a lot of modules, we should try to keep it clean, at least for version 9.

@rafaelbn
Copy link
Member

rafaelbn commented Sep 4, 2015

IMO we must move this four to sale-workflow. I agree with moving:

  • sale_quick_payment
  • sale_sale_payment_method
  • sale_automatic_workflow
  • sale_payment_method_automatic_workflow

Nothing has to be with e-commerce (website_sale - that why the name was discussed here).

In fact is more related with connector than Odoo's e-commerce.

About this theme, we are working in several e-commerce with Odoo, and we need to have different workflows depending if the sale is from backend or from e-commerce (obviously) and this means that we will work in (near future):

  • website_sale_quick_payment
  • website_sale_sale_payment_method
  • website_sale_automatic_workflow
  • website_sale_payment_method_automatic_workflow

@gurneyalex
Copy link
Member Author

I'll change this over the week end.

@gurneyalex gurneyalex self-assigned this Sep 4, 2015
@rafaelbn
Copy link
Member

Hello, please when possible change this PR to https://github.com/OCA/sale-workflow as discussed.
Also discussed here: #47
Thanks

@rafaelbn rafaelbn mentioned this pull request Nov 26, 2015
17 tasks
@gurneyalex
Copy link
Member Author

Hi all,

I'm totally under the water, and need help on these PRs. I'd be very grateful if someone could pick them up and do the migration. @lepistone maybe you could lend me a hand here?

😻

@lepistone lepistone assigned lepistone and unassigned gurneyalex Dec 1, 2015
@lepistone
Copy link
Member

ok, I'm picking this up.

lepistone added a commit to lepistone/e-commerce that referenced this pull request Dec 1, 2015
@lepistone
Copy link
Member

Superseded by #86 and OCA/sale-workflow#239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants