[13.0][MIG] quality_control #481

ps-tubtim · 2020-03-17T08:44:21Z

No description provided.

Daniel-CA · 2020-04-23T07:29:06Z

Hello,
Maybe this is not the best place to talk about this issue but is there any idea to separate the quality modules from the manufacture repository to avoid collisions with the Odoo quality modules? As you know Odoo has his own quality_control and there are some problems if you link the enterprise and manufacture branch in the same system.

pedrobaeza · 2020-04-23T07:31:00Z

Don't import whole OCA/manufacture repo, but the real issue is to have the same name. Odoo steals ours, because this module exists from before they created enterprise one, but yes, we have to adapt as they have the "power" in this.

Daniel-CA · 2020-04-23T07:45:41Z

Hi Pedro,
Yes I know that has not been a good practice from Odoo to name the module as our own, and we are doing like you say, not importing whole manufacture repository.

jarroyomorales

Code and functional review. Some view comments

Also I dont understand how to create a qc_trigger, what am I missing?

jarroyomorales · 2020-09-30T10:41:52Z

quality_control/__manifest__.py

+    "category": "Quality control",
+    "license": "AGPL-3",
+    "summary": "Generic infrastructure for quality tests.",
+    "author": "OdooMRP team, " "Odoo Community Association (OCA)",


Join strings

jarroyomorales · 2020-09-30T10:48:27Z

quality_control/models/qc_inspection.py

+        required=True,
+        default="/",
+        readonly=True,
+        states={"draft": [("readonly", False)]},


I think if we are using a sequence it should always be readonly

jarroyomorales · 2020-09-30T10:55:31Z

quality_control/views/qc_inspection_view.xml

+                            <field name="user" />
+                            <field name="object_id" />
+                            <field name="qty" />
+                            <field name="product_id" />


why showing product_id if you can already see it on object_id?

jarroyomorales · 2020-09-30T11:01:24Z

quality_control/views/qc_inspection_view.xml

+                    />
+                </header>
+                <sheet>
+                    <div class="oe_button_box" name="buttons">


This div is usually called name="button_box" and it adds some css

jarroyomorales · 2020-09-30T11:02:43Z

quality_control/views/qc_inspection_view.xml

+                <sheet>
+                    <div class="oe_button_box" name="buttons">
+                        <button
+                            class="oe_inline oe_stat_button"


It is easier to read without the oe_inline

jarroyomorales · 2020-09-30T11:07:45Z

quality_control/wizard/qc_test_wizard_view.xml

+                        class="oe_highlight"
+                    />
+                    or
+                    <button special="cancel" class="oe_link" string="Cancel" />


class="btn-secondary" looks better IMO

jarroyomorales · 2020-09-30T11:12:02Z

quality_control/views/qc_test_view.xml

+                        </tree>
+                    </field>
+                </group>
+                <div


Maybe this div could be improved since values appear very big and its not clear what they are supposed to be.

pedrobaeza · 2020-11-19T15:11:26Z

For not collapsing with enterprise, we need to rename this module to quality_control_oca or similar.

* Fixing problems

…d new concepts. * Triggers for product category * ACLs * Tolerances in questions * one2many copyable * Fix some views * Error on same tolerance * Colors on inspection lines * Unify inspection header data assignment in set_test method * key name in set_test * Change icon set

…les * Trigger line instead of test and user

* Expand AUTHORS * Fix permissions

…e.now

* security modified * some demo info added * Added "partner_selectable" field, so that inspections can by made by partner * Little view fixing, field was oe_edit_only instead of label * Add partners to trigger lines * Tests added * Trigger lines with duplicated test cleaned quality_control: Propose to OCA quality_control: required changes quality_control: Fixing coveralls quality_control_stock: * added demo data * replaced unlink method by ondelete="cascade" * required changes

Making it a regular field, you can put any manual quantity in inspections

* validation errors now raise exceptions.ValidationError, and other errors raise UserError * Treaceability of inspection status * using fa icons instead of gtk * get ir_sequence.get method is deprecated

…to quality_control module to avoid runbot warning

…riants + permissions (OCA#325)

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-12.0/manufacture-12.0-quality_control Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-quality_control/

…r group by default.

Currently translated at 98.1% (154 of 157 strings) Translation: manufacture-12.0/manufacture-12.0-quality_control Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-quality_control/pt/

Fixed Quality Control Trigger 'trigger' selector in Product Template and Product Category.

Currently translated at 77.1% (121 of 157 strings) Translation: manufacture-12.0/manufacture-12.0-quality_control Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-quality_control/hr/

CarlosRoca13 · 2021-01-25T15:08:53Z

quality_control_oca/__manifest__.py

+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+{
+    "name": "Quality Control",


Suggested change

"name": "Quality Control",

"name": "Quality Control OCA",

CarlosRoca13 · 2021-01-25T15:23:48Z

quality_control_oca/models/qc_inspection.py

+                raise exceptions.UserError(
+                    _("You cannot remove an inspection that is not in draft state.")
+                )
+        return super(QcInspection, self).unlink()


Suggested change

return super(QcInspection, self).unlink()

return super().unlink()

CarlosRoca13 · 2021-01-25T15:24:10Z

quality_control_oca/tests/test_quality_control.py

+
+class TestQualityControl(TransactionCase):
+    def setUp(self):
+        super(TestQualityControl, self).setUp()


Suggested change

super(TestQualityControl, self).setUp()

super().setUp()

pedrobaeza · 2021-02-13T15:28:49Z

Superseded by #595

ps-tubtim mentioned this pull request Mar 17, 2020

[13.0][MIG] quality_control ecosoft-odoo/kanban#180

Open

ps-tubtim force-pushed the 13.0-mig-quality_control branch from 1ef1eaa to 34d003c Compare March 17, 2020 10:10

LoisRForgeFlow added this to the 13.0 milestone Mar 17, 2020

LoisRForgeFlow added the needs review label Mar 17, 2020

OCA-git-bot mentioned this pull request Mar 17, 2020

Migration to version 13.0 #408

Closed

19 tasks

This was referenced Mar 20, 2020

[13.0][MIG] quality_control_stock #483

Closed

[13.0][MIG] quality_control_team #484

Closed

[13.0][MIG] quality_control_issue #486

Closed

jarroyomorales reviewed Sep 30, 2020

View reviewed changes

pedrobaeza mentioned this pull request Nov 19, 2020

[12.0] [FIX] rename quality_control to quality_control_oca #559

Closed

oihane and others added 16 commits November 24, 2020 10:53

Modulos de calidad sin migrar

00fd371

quality_control * PEP8 * Travis * Size in field (deprecated)

d5f9e66

no msg

1f00015

quality_control: Some improvement

94845a1

no msg

39ae0db

<quality_control> deleted constraint

855aa1b

no msg

13a074d

quality_control: * Made line tree editable on test templates

09bae58

* Fixing problems

New module <quality_control_hr> closes OCA#662 * Changes in access ru…

e69ed4e

…les * Trigger line instead of test and user

quality_control * Fix wizard set test

0b6f493

* Expand AUTHORS * Fix permissions

changed default references of fields.Datetime.now() to fields.Datetim…

5b4b39e

…e.now

Slovene translations added

21a2214

quality_control_*: Make use of qty field

8ad2b41

Making it a regular field, you can put any manual quantity in inspections

quality_control: deleting qc.inspection does not delete its lines fixed

6642004

SimoRubi and others added 23 commits November 24, 2020 10:53

[FIX+IMP] quality_control: Several things:

e53ecbb

* validation errors now raise exceptions.ValidationError, and other errors raise UserError * Treaceability of inspection status * using fa icons instead of gtk * get ir_sequence.get method is deprecated

[UPD] Update quality_control.pot

d57fe5a

[MIG] quality_control: Migration to 11.0

c5c61dd

[UPD] Update quality_control.pot

279abee

[11.0][FIX] quality_control: Fixed dashboard icon. (OCA#304)

0956af6

[10.0][FIX] quality_control: move quality control configuration menu …

5ec24c7

…to quality_control module to avoid runbot warning

[UPD] Update quality_control.pot

15889e0

[FIX] quality_control: created new notebook page to avoid activate va…

2fcf05c

…riants + permissions (OCA#325)

[IMP] quality_control: App drawer icon

19aa02b

[MIG] quality_control: Migration to 12.0

24ede83

[UPD] README.rst

e9be14f

[UPD] Update quality_control.pot

9a48e73

Update translation files

60c2ff9

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-12.0/manufacture-12.0-quality_control Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-quality_control/

[12.0][FIX] quality_control: add user admin to quality control manage…

08d1052

…r group by default.

[UPD] README.rst

3217cff

[UPD] Update module logo

5008ffc

quality_control 12.0.1.1.0

fcd9dea

Translated using Weblate (Portuguese)

cce290d

Currently translated at 98.1% (154 of 157 strings) Translation: manufacture-12.0/manufacture-12.0-quality_control Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-quality_control/pt/

[FIX] quality_control

e918ce5

Fixed Quality Control Trigger 'trigger' selector in Product Template and Product Category.

quality_control 12.0.1.2.0

e146658

Translated using Weblate (Croatian)

a339ad9

Currently translated at 77.1% (121 of 157 strings) Translation: manufacture-12.0/manufacture-12.0-quality_control Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-quality_control/hr/

[IMP] quality_control: black, isort

43d0696

[MIG] quality_control: Migration to 13.0

9b1abd0

ps-tubtim force-pushed the 13.0-mig-quality_control branch from 34d003c to 9b1abd0 Compare November 24, 2020 03:53

Rename quality_control to quality_control_oca

a0fdf42

CarlosRoca13 reviewed Jan 25, 2021

View reviewed changes

CarlosRoca13 mentioned this pull request Feb 8, 2021

[13.0] [MIG] quality_control_oca: Migration to v13.0 #595

Merged

pedrobaeza closed this Feb 13, 2021

primes2h mentioned this pull request Feb 13, 2021

[14.0] Migration: l10n_it_esigibilita_iva OCA/l10n-italy#1938

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] quality_control #481

[13.0][MIG] quality_control #481

ps-tubtim commented Mar 17, 2020

Daniel-CA commented Apr 23, 2020

pedrobaeza commented Apr 23, 2020

Daniel-CA commented Apr 23, 2020

jarroyomorales left a comment

jarroyomorales Sep 30, 2020

jarroyomorales Sep 30, 2020

jarroyomorales Sep 30, 2020

jarroyomorales Sep 30, 2020

jarroyomorales Sep 30, 2020

jarroyomorales Sep 30, 2020

jarroyomorales Sep 30, 2020

pedrobaeza commented Nov 19, 2020

CarlosRoca13 Jan 25, 2021

CarlosRoca13 Jan 25, 2021

CarlosRoca13 Jan 25, 2021

pedrobaeza commented Feb 13, 2021

	return super(QcInspection, self).unlink()
	return super().unlink()

[13.0][MIG] quality_control #481

[13.0][MIG] quality_control #481

Conversation

ps-tubtim commented Mar 17, 2020

Daniel-CA commented Apr 23, 2020

pedrobaeza commented Apr 23, 2020

Daniel-CA commented Apr 23, 2020

jarroyomorales left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Feb 13, 2021