Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] quality_control: created new notebook page to avoid activate variants #325

Merged
merged 3 commits into from
Dec 19, 2018

Conversation

oihane
Copy link
Contributor

@oihane oihane commented Dec 17, 2018

cc @anajuaristi @pedrobaeza

This fix is to avoid selecting "Manage Product Variants"

@pedrobaeza
Copy link
Member

Please try to locate it in other place instead on a new page.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Dec 17, 2018
@oihane
Copy link
Contributor Author

oihane commented Dec 17, 2018

The pages available are

  • General Information
  • Sales (only for product that can be sold)
  • Inventory (only for products that are not services, and limited by permission)
  • Notes
<page string="General Information" name="general_information">
<page string="Sales" attrs="{'invisible':[('sale_ok','=',False)]}" name="sales">
<page string="Inventory" name="inventory" groups="stock.group_stock_user,product.group_stock_packaging" attrs="{'invisible':[('type', '=', 'service')]}">
<page string="Notes" name="notes">

Should I locate it in General Information?

@pedrobaeza
Copy link
Member

Quality control is applicable to services? I don't remember anything about that, so "Inventory" might be a good place.

@pedrobaeza
Copy link
Member

@lreficent anything by your side that you are using this if I don't remember bad?

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me 👍

@pedrobaeza pedrobaeza merged commit 199bfbb into OCA:11.0 Dec 19, 2018
NachoAlesLopez pushed a commit to NachoAlesLopez/manufacture that referenced this pull request May 10, 2019
NachoAlesLopez pushed a commit to NachoAlesLopez/manufacture that referenced this pull request May 10, 2019
LoisRForgeFlow pushed a commit that referenced this pull request Jun 6, 2019
rvalyi pushed a commit to akretion/manufacture that referenced this pull request Mar 3, 2020
ps-tubtim pushed a commit to ecosoft-odoo/manufacture that referenced this pull request Mar 17, 2020
ps-tubtim pushed a commit to ecosoft-odoo/manufacture that referenced this pull request Nov 24, 2020
CarlosRoca13 pushed a commit to Tecnativa/manufacture that referenced this pull request Feb 8, 2021
pedrobaeza pushed a commit to Tecnativa/manufacture that referenced this pull request Feb 13, 2021
CarlosRoca13 pushed a commit to Tecnativa/manufacture that referenced this pull request Feb 15, 2021
CarlosRoca13 pushed a commit to Tecnativa/manufacture that referenced this pull request Feb 22, 2021
CarlosRoca13 pushed a commit to Tecnativa/manufacture that referenced this pull request Mar 2, 2021
enriquemartin pushed a commit to Digital5-Odoo/manufacture that referenced this pull request Mar 5, 2021
enriquemartin pushed a commit to Digital5-Odoo/manufacture that referenced this pull request Apr 21, 2021
enriquemartin pushed a commit to Digital5-Odoo/manufacture that referenced this pull request Oct 1, 2021
hpatelserpentcs pushed a commit to hpatelserpentcs/manufacture that referenced this pull request Dec 29, 2021
mymage pushed a commit to mymage/manufacture that referenced this pull request Dec 10, 2022
mymage pushed a commit to mymage/manufacture that referenced this pull request Dec 26, 2022
mymage pushed a commit to mymage/manufacture that referenced this pull request Jan 17, 2023
peluko00 pushed a commit to APSL/manufacture that referenced this pull request May 14, 2024
Trivedi-Vacha-SerpentCS pushed a commit to Trivedi-Vacha-SerpentCS/manufacture that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants