Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] l10n_it_fatturapa_pec state related source strings #736

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Dec 16, 2018

Add 'state' reference in source strings to simplify translation work (avoid issues with plural forms).

@primes2h primes2h force-pushed the 12.0-imp-l10n_it_fatturapa_pec-state-related-source-strings branch from 9325a94 to ca70157 Compare December 16, 2018 17:17
@primes2h primes2h changed the title [IMP] l10n_it_fatturapa_pec state related source strings [12.0][IMP] l10n_it_fatturapa_pec state related source strings Dec 16, 2018
@primes2h
Copy link
Contributor Author

Up

@eLBati
Copy link
Member

eLBati commented Dec 27, 2018

Beta module, merging.

@primes2h please then verify weblate translations.
Thanks

@primes2h
Copy link
Contributor Author

Beta module, merging.

@primes2h please then verify weblate translations.
Thanks

Sure 👍

@primes2h
Copy link
Contributor Author

@sbidoul
This PR (#736) and PR #735 have both the same changes, have been merged at the same time, the only difference is module version (12.0 and 10.0).

it.po file of 10.0 has been updated
https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_fatturapa_pec/it/

.pot file of 12.0 has been updated but it.po unfortunately not:
https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_fatturapa_pec/it/

May you check please?

@sbidoul
Copy link
Member

sbidoul commented Dec 28, 2018

I'm running out of ideas. Opening a discussion at weblate WeblateOrg/weblate#2107 (comment)

In the meantime I ran a manual update for l10n-italy, please check it.

@primes2h
Copy link
Contributor Author

I'm running out of ideas. Opening a discussion at weblate WeblateOrg/weblate#2107 (comment)

👍

In the meantime I ran a manual update for l10n-italy, please check it.

Updated, thanks!

@primes2h
Copy link
Contributor Author

@sbidoul

I ran odoo-bin with --i18n-overwrite option to update db translations and I got several messages like this one:

2018-12-28 20:25:45,226 8851 INFO odoo12-test odoo.tools.translate: Translation 'First name' (model, ir.model.fields,field_description, partner_firstname.field_res_partner_firstname) not found in reference pot, skipping

In fact I found out that same problem affects:
at least other 2 OCA modules, partner-contact/partner_firstname and account-financial-reporting/account_tax_balance (12.0).
pot files are updated but it.po ones are not.

but, OCB modules are affected too:
e.g. account
Last week I opened this PR:
odoo/odoo#29690
merged 3 days ago.
In OCB, account.pot file has been updated accordingly, it.po not.

I hope these findings help you.

P.S.: could you please update these modules manually? Thanks.

@sbidoul
Copy link
Member

sbidoul commented Dec 29, 2018

@primes2h I ran a manual update on all OCA.

Regarding OCB, we don't manage the OCB translations in OCA. You should translate on Odoo's transifex and they will be brought to OCB as part of the nightly OCB sync with upstream Odoo.

@primes2h
Copy link
Contributor Author

@sbidoul
Thanks!

About OCB, I was referring to mismatch between .pot and .po source strings.
You mean that Odoo/Transifex sync is not on a daily basis (as OCB/Odoo code is)?

@sbidoul
Copy link
Member

sbidoul commented Dec 29, 2018

You mean that Odoo/Transifex sync is not on a daily basis (as OCB/Odoo code is)?

I don't know. Have you checked on Transifex if the new terms are there? Perhaps the .po is updated only when something is translated on transifex. @mart-e must know.

@mart-e
Copy link

mart-e commented Dec 31, 2018

Hi,

The usual flow is the following:

  1. the .pot is updated on odoo/odoo on github
  2. transifex watches the .pot file, it notices the changes and update the resource <-- this step failed
  3. a new translation is made to transifex
  4. the translations are synced from transifex to odoo/odoo every Sunday
  5. OCA/OCB sync lasts commits from odoo/odoo in their daily sync

The step 2 failed as Transifex somehow got an error when reading the file on github. I have manually forced the sync and the new terms are on Transifex.
At the next synchronisation from transifex to github, the it.po file will be updated.

@primes2h
Copy link
Contributor Author

Hi,

The usual flow is the following:

1. the .pot is updated on odoo/odoo on github

2. transifex watches the .pot file, it notices the changes and update the resource  <-- this step failed

3. a new translation is made to transifex

4. the translations are synced from transifex to odoo/odoo every Sunday

5. OCA/OCB sync lasts commits from odoo/odoo in their daily sync

The step 2 failed as Transifex somehow got an error when reading the file on github. I have manually forced the sync and the new terms are on Transifex.
At the next synchronisation from transifex to github, the it.po file will be updated.

@mart-e
Thanks for the clarification.

@primes2h primes2h deleted the 12.0-imp-l10n_it_fatturapa_pec-state-related-source-strings branch February 3, 2019 13:38
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 2, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 16, 2021
fredzamoabg pushed a commit to fredzamoabg/l10n-italy that referenced this pull request Apr 23, 2021
fredzamoabg pushed a commit to fredzamoabg/l10n-italy that referenced this pull request Apr 23, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 30, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request May 6, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request May 7, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request May 28, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jun 4, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Jun 6, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 9, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 8, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 22, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Nov 2, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Nov 16, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Nov 20, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Dec 10, 2021
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jan 28, 2022
OCA-git-bot pushed a commit to Borruso/l10n-italy that referenced this pull request Feb 4, 2022
iwkse pushed a commit to iwkse/l10n-italy that referenced this pull request Feb 5, 2022
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Feb 24, 2023
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Apr 20, 2023
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Apr 21, 2023
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jun 23, 2023
Borruso pushed a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jul 13, 2023
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jul 21, 2023
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jul 21, 2023
odooNextev pushed a commit to odooNextev/l10n-italy that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants