[11.0][MIG] l10n it split payment: Migration to 11.0 #525

jackjack82 · 2018-06-27T12:06:39Z

No description provided.

eLBati

LGTM

eLBati · 2018-06-30T05:45:51Z

@jackjack82 ci sarebbe da fare rebase + squash dei gruppi di commit con lo stesso autore

jackjack82 · 2018-07-02T08:20:10Z

@eLBati quindi mergiare i commit di trasbot, così come anche i tuoi? Ad esempio mergiare insieme
23b880c, a574f59 e 09fbf1e?

jackjack82 · 2018-07-02T15:53:26Z

@eLBati squashed

eLBati · 2018-07-03T07:05:14Z

l10n_it_split_payment/__manifest__.py

+    'summary': 'Split Payment',
+    'author': 'Abstract, Agile Business Group, '
+              'Odoo Community Association (OCA)',
+    'website': 'http://www.abstract.it',


Metterei https://github.com/OCA/l10n-italy come website

eLBati · 2018-07-03T07:05:22Z

l10n_it_split_payment/__manifest__.py

+              'Odoo Community Association (OCA)',
+    'website': 'http://www.abstract.it',
+    'license': 'AGPL-3',
+    'depends': ['account'],


@jackjack82 penso debba dipendere anche da account_invoicing

eLBati · 2018-07-03T07:35:15Z

Per il resto direi OK

jackjack82 · 2018-07-03T09:07:21Z

@eLBati edited manifest.py, added account_invoicing and new website. can merge.

eLBati

grazie

eLBati · 2018-07-06T15:12:39Z

I commit 5ca325c e 6d67b87 non dovrebbero essere qua , in quanto già in 11.0
Per aggiungerli alla build di questa PR, devi fare rebase su 11.0

Removing superfluous method Refactoring action_move_create with reconciliation handling invoice cancel ADD README and copyright REF _compute_amount : clearer ADD tests FIX README, import, icon and manifest ADD _unreconcile_sp

…-tools#234

REF split_payment setting invoice total credit = amount to pay Remove old useless field

…ymore FIX journal entry of refund

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

otherwise you could get into errors like File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/addons/account/account_invoice.py", line 647, in button_reset_taxes account_invoice_tax.create(taxe) File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/api.py", line 266, in wrapper return new_api(self, *args, **kwargs) File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/models.py", line 4093, in create record = self.browse(self._create(old_vals)) File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/api.py", line 266, in wrapper return new_api(self, *args, **kwargs) File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/api.py", line 508, in new_api result = method(self._model, cr, uid, *args, **old_kwargs) File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/models.py", line 4303, in _create recs.recompute() File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/api.py", line 266, in wrapper return new_api(self, *args, **kwargs) File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/models.py", line 5756, in recompute name: rec[name] for name in names File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/models.py", line 5756, in <dictcomp> name: rec[name] for name in names File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/models.py", line 5640, in __getitem__ return self._fields[key].__get__(self, type(self)) File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/fields.py", line 840, in __get__ return record._cache[self] File "/srv/odoo-8-agilebg-test/agilebg/parts/odoo/openerp/models.py", line 6022, in __getitem__ value = self._recs.env.cache[field][self._recs.id] KeyError: 663

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

…t_invoice_sequential_dates Refactoring for variables name to be more clear

OCA Transbot updated translations from Transifex

l10n_it_split_payment FIX tests porting to 10 l10n_it_split_payment FIX translation and README

eLBati · 2018-08-16T12:55:56Z

@jackjack82 se puoi dai un'occhiata a #570 ed eventualmente includi le modifiche in questa PR

labaggio · 2018-10-25T07:55:24Z

@eLBati cosa manca per mergiare questa PR?

eLBati · 2018-10-25T08:15:44Z

@labaggio includere la #570

SimoRubi

Solo review del codice, ho segnato da fare qualche refactoring ma possiamo soprassedere visto che è una PR di migrazione

SimoRubi · 2018-11-08T11:56:30Z

l10n_it_split_payment/models/account.py

+        'Split Payment',
+        related='fiscal_position_id.split_payment')
+
+    @api.one


SimoRubi · 2018-11-08T11:56:43Z

l10n_it_split_payment/models/account.py

+        # return the move line ids with the same account as the invoice self
+        if not self.id:
+            return []
+        query = (


Meglio usare ORM

SimoRubi · 2018-11-08T11:57:35Z

l10n_it_split_payment/models/account.py

+
+    @api.multi
+    def get_receivable_line_ids(self):
+        # return the move line ids with the same account as the invoice self


Suggested change

# return the move line ids with the same account as the invoice self

# return the move line ids with the same account as the invoice self

self.ensure_one()

SimoRubi · 2018-11-08T12:00:46Z

l10n_it_split_payment/models/account.py

+        res = super(AccountInvoice, self).action_move_create()
+        for invoice in self:
+            if (
+                invoice.fiscal_position_id and


Puoi controllare direttamente il campo related sulla fattura

ruben-tonetto · 2018-11-08T19:40:05Z

La prendo in carico io

ruben-tonetto · 2018-11-08T21:11:32Z

Aperta la PR #652

eLBati · 2018-11-08T22:58:17Z

Chiudo allora questa

jackjack82 changed the title ~~11.0 mig l10n it split payment~~ [11.0][MIG] l10n it split payment: Migration to 11.0 Jun 28, 2018

pedrobaeza mentioned this pull request Jun 30, 2018

Migration to version 11.0 #391

Closed

35 tasks

eLBati approved these changes Jun 30, 2018

View reviewed changes

jackjack82 force-pushed the 11.0-mig-l10n_it_split_payment branch from b92ef50 to aff6770 Compare July 2, 2018 15:49

eLBati requested changes Jul 3, 2018

View reviewed changes

jackjack82 force-pushed the 11.0-mig-l10n_it_split_payment branch from aff6770 to 1d9139d Compare July 3, 2018 07:46

alessandrocamilli added the 11.0 label Jul 5, 2018

eLBati approved these changes Jul 6, 2018

View reviewed changes

Davide Corio and others added 16 commits July 6, 2018 17:19

[IMP] 1st working mockup

5cc1b6a

Removing sp_type as 1-entry would produce wrong invoice

c81f6ae

Removing superfluous method Refactoring action_move_create with reconciliation handling invoice cancel ADD README and copyright REF _compute_amount : clearer ADD tests FIX README, import, icon and manifest ADD _unreconcile_sp

Fix errors raised by test_pylint, according to OCA/maintainer-quality…

71911fc

…-tools#234

Remove required constraint from configuration fields

dbbe91e

REF split_payment setting invoice total credit = amount to pay Remove old useless field

OCA Transbot updated translations from Transifex

fc8163e

[MIG] Make modules uninstallable

43946ba

[FIX] remove en.po that was erroneously created by transbot

b3c305a

[MIG] Rename manifest files

b3c7064

OCA Transbot updated translations from Transifex

08b5fdf

remove statement about split payment journal, as it is not present an…

462b828

…ymore FIX journal entry of refund

OCA Transbot updated translations from Transifex

e336771

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex

fdb2dc0

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

Solve problem with tests of l10n_it_split_payment after add of accoun…

1e32bd6

…t_invoice_sequential_dates Refactoring for variables name to be more clear

OCA Transbot updated translations from Transifex

ffae08c

OCA Transbot updated translations from Transifex

[MIG] l10n_it_split_payment: Migrated to 10.0

ef11cc3

eLBati and others added 3 commits July 6, 2018 17:19

l10n_it_split_payment IMP README with new screenshots

9bef381

l10n_it_split_payment FIX tests porting to 10 l10n_it_split_payment FIX translation and README

OCA Transbot updated translations from Transifex

3278d3e

[11] migrating split payment

1f41484

jackjack82 force-pushed the 11.0-mig-l10n_it_split_payment branch from 7d2053a to 1f41484 Compare July 6, 2018 15:19

eLBati approved these changes Jul 6, 2018

View reviewed changes

labaggio mentioned this pull request Nov 5, 2018

[11.0] mig l10n_it_fatturapa #639

Merged

francesca-bianchini mentioned this pull request Nov 6, 2018

[11.0] mig l10n_it_fatturapa_out #641

Merged

SimoRubi approved these changes Nov 8, 2018

View reviewed changes

ruben-tonetto mentioned this pull request Nov 8, 2018

[11.0] mig l10n_it_split_payment (rt) #652

Merged

eLBati closed this Nov 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] l10n it split payment: Migration to 11.0 #525

[11.0][MIG] l10n it split payment: Migration to 11.0 #525

jackjack82 commented Jun 27, 2018

eLBati left a comment

eLBati commented Jun 30, 2018

jackjack82 commented Jul 2, 2018

jackjack82 commented Jul 2, 2018

eLBati Jul 3, 2018

eLBati Jul 3, 2018

eLBati commented Jul 3, 2018

jackjack82 commented Jul 3, 2018

eLBati left a comment

eLBati commented Jul 6, 2018

eLBati commented Aug 16, 2018

labaggio commented Oct 25, 2018

eLBati commented Oct 25, 2018

SimoRubi left a comment

SimoRubi Nov 8, 2018

SimoRubi Nov 8, 2018

SimoRubi Nov 8, 2018

SimoRubi Nov 8, 2018

ruben-tonetto commented Nov 8, 2018

ruben-tonetto commented Nov 8, 2018

eLBati commented Nov 8, 2018

	# return the move line ids with the same account as the invoice self
	# return the move line ids with the same account as the invoice self
	self.ensure_one()

[11.0][MIG] l10n it split payment: Migration to 11.0 #525

[11.0][MIG] l10n it split payment: Migration to 11.0 #525

Conversation

jackjack82 commented Jun 27, 2018

eLBati left a comment

Choose a reason for hiding this comment

eLBati commented Jun 30, 2018

jackjack82 commented Jul 2, 2018

jackjack82 commented Jul 2, 2018

eLBati Jul 3, 2018

Choose a reason for hiding this comment

eLBati Jul 3, 2018

Choose a reason for hiding this comment

eLBati commented Jul 3, 2018

jackjack82 commented Jul 3, 2018

eLBati left a comment

Choose a reason for hiding this comment

eLBati commented Jul 6, 2018

eLBati commented Aug 16, 2018

labaggio commented Oct 25, 2018

eLBati commented Oct 25, 2018

SimoRubi left a comment

Choose a reason for hiding this comment

SimoRubi Nov 8, 2018

Choose a reason for hiding this comment

SimoRubi Nov 8, 2018

Choose a reason for hiding this comment

SimoRubi Nov 8, 2018

Choose a reason for hiding this comment

SimoRubi Nov 8, 2018

Choose a reason for hiding this comment

ruben-tonetto commented Nov 8, 2018

ruben-tonetto commented Nov 8, 2018

eLBati commented Nov 8, 2018