Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

[ADD] pylint_oca: Add pylint plugin script to check OCA guidelines #234

Merged
merged 3 commits into from
Sep 14, 2015

Conversation

moylop260
Copy link
Contributor

  • Add new feature to check odoo guidelines with a pylint-plugin.
    • Add compatibility to check manifest file __openerp__.py
    • New checks available for all versions just in modules changed:
      • C8101 - Missing author required "%s" in manifest file - manifest-required-author
        • Odoo Community Association (OCA)
      • C8102 - Missing required key "%s" in manifest file - manifest-required-key
        • license
      • C8103 - Deprecated key "%s" in manifest file - manifest-deprecated-key
        • description and active except for odoo <= 70
      • C8201 - No UTF-8 coding found: Use # -*- coding: utf-8 -*- - no-utf8-coding-comment
      • E7901 - RST syntax error %s - rst-syntax-error
      • W7901 - Dangerous filter without explicit user_id in xml_id %s - dangerous-filter-wo-user
      • W7902 - Duplicate xml record id %s - duplicate-xml-record-id
      • W8101 - Detected api.one and api.multi decorators together. - api-one-multi-together
      • W8201 - Incoherent interpreter comment and executable permission. Interpreter: [%s] Exec perm: %s - incoherent-interpreter-exec-perm
      • W8202 - Use of vim comment - use-vim-comment
    • New checks available for all versions except for odoo <= 70 in modules changed:
      • C7902 - Missing ./README.rst file. Template here: %s - missing-readme
      • C8104 - Use CamelCase "%s" in class name "%s". You can use oca-autopep8 of https://github.com/OCA/maintainer-tools to auto fix it. - class-camelcase
      • R8101 - Import Warning should be renamed as UserError from openerp.exceptions import Warning as UserError - openerp-exception-warning
      • W8102 - Missing api.one in copy function. - copy-wo-api-one

%s is extracted from config_file.

Example of comments:

Example result:
captura de pantalla 2015-09-04 a las 1 52 43 a m

@moylop260 moylop260 force-pushed the oca-odoo-lint-moy branch 3 times, most recently from 5390afe to 2127ec4 Compare August 18, 2015 21:29
@moylop260 moylop260 self-assigned this Aug 18, 2015
@moylop260 moylop260 force-pushed the oca-odoo-lint-moy branch 4 times, most recently from ee7d1c2 to 251a3ad Compare August 23, 2015 04:55
@moylop260 moylop260 changed the title [ADD] odoo_lint: Add pylint plugin script to check odoo guidelines [ADD] pylint_oca: Add pylint plugin script to check OCA guidelines Aug 23, 2015
@moylop260 moylop260 force-pushed the oca-odoo-lint-moy branch 9 times, most recently from 329a24e to 5f0161a Compare August 25, 2015 03:39
@moylop260 moylop260 mentioned this pull request Sep 2, 2015
8 tasks
@moylop260 moylop260 force-pushed the oca-odoo-lint-moy branch 4 times, most recently from 3b48a9c to cfe5c5f Compare September 4, 2015 06:02
@moylop260
Copy link
Contributor Author

@nhomar @pedrobaeza
Could you merge it?

@nhomar
Copy link
Member

nhomar commented Sep 14, 2015

2 +1 then I merge.

nhomar added a commit that referenced this pull request Sep 14, 2015
[ADD] pylint_oca: Add pylint plugin script to check OCA guidelines
@nhomar nhomar merged commit f87fd22 into OCA:master Sep 14, 2015
@nhomar nhomar deleted the oca-odoo-lint-moy branch September 14, 2015 03:53
tafaRU added a commit to tafaRU/l10n-italy that referenced this pull request Sep 16, 2015
eLBati pushed a commit to eLBati/l10n-italy that referenced this pull request Sep 17, 2015
eLBati pushed a commit to eLBati/l10n-italy that referenced this pull request Oct 6, 2015
jackjack82 pushed a commit to jackjack82/l10n-italy that referenced this pull request Jun 27, 2018
jackjack82 pushed a commit to jackjack82/l10n-italy that referenced this pull request Jul 2, 2018
jackjack82 pushed a commit to jackjack82/l10n-italy that referenced this pull request Jul 6, 2018
ruben-tonetto pushed a commit to ruben-tonetto/l10n-italy that referenced this pull request Nov 12, 2018
eLBati pushed a commit to eLBati/l10n-italy that referenced this pull request Nov 16, 2018
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Aug 7, 2019
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Nov 20, 2020
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 9, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 16, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 23, 2021
tafaRU added a commit to tafaRU/l10n-italy that referenced this pull request Apr 23, 2021
tafaRU added a commit to tafaRU/l10n-italy that referenced this pull request Apr 23, 2021
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jan 13, 2023
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jun 16, 2023
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jun 23, 2023
Borruso pushed a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jul 13, 2023
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Sep 7, 2023
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Sep 25, 2023
Wodran14 pushed a commit to DynAppsNV/l10n-italy that referenced this pull request Apr 11, 2024
TennyMkt pushed a commit to mktsrl/l10n-italy that referenced this pull request May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants