Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX] migration e-invoice 1.6 #1914

Merged
merged 3 commits into from
Dec 15, 2020
Merged

[12.0][FIX] migration e-invoice 1.6 #1914

merged 3 commits into from
Dec 15, 2020

Conversation

sergiocorato
Copy link
Contributor

@sergiocorato sergiocorato commented Oct 10, 2020 •
edited
Loading

Descrizione del problema o della funzionalità: la migrazione dalla 11.0 fallisce perchè manca il campo ftpa_withholding_amount aggiunto e tolto sulla 12.0

Comportamento attuale prima di questa PR: la migrazione da una versione precedente la 12.0 fallisce

Comportamento desiderato dopo questa PR: la migrazione da una versione precedente la 12.0 va a buon fine

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@sergiocorato sergiocorato force-pushed the 12.0_fix_l10n_it_fatturapa_in-migr-1.6 branch 5 times, most recently from 2612285 to 42711d3 Compare October 11, 2020 07:50
@sergiocorato sergiocorato force-pushed the 12.0_fix_l10n_it_fatturapa_in-migr-1.6 branch from 42711d3 to ccb0e4c Compare October 11, 2020 08:10
@matteoopenf
Copy link
Contributor

matteoopenf commented Oct 12, 2020 •
edited
Loading

molto utile ho rilevato anche io il medesimo problema

@sergiocorato sergiocorato mentioned this pull request Oct 16, 2020
Merged
tafaRU
tafaRU requested changes Oct 16, 2020
View reviewed changes
l10n_it_fatturapa_in/migrations/12.0.2.0.0/post-migration.py Outdated
openupgrade.logged_query(
env.cr, sql.SQL(
"""
INSERT INTO withholding_data_line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considerato che tra questa INSERT e la successiva cambia solo una colonna, potresti provare ad accorparle in una sola utilizzando le espressioni condizionali di PostgreSQL? Es. IF o NULLIF.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Riesci a fare una PR a riguardo? Dovrei approfondire, al momento sono un po' tirato.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

efatto#1

Copy link
Member

@tafaRU tafaRU Dec 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiocorato prima di mergiare la mia PR l'hai anche testata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, ho solo guardato il codice

@sergiocorato sergiocorato mentioned this pull request Nov 3, 2020
Closed
@scigghia
Copy link
Contributor

scigghia commented Nov 4, 2020

se quel campo è stato rimosso, cosa lo sostituiscie? possiamo considerarlo sempre null e bypassare quelle due query oppure provocherebbe un disastro?

tafaRU and others added 2 commits December 10, 2020 16:49
@tafaRU
l10n_it_fatturapa_in: avoid duplication in the code of post migration…
e15f365 
… script (DRY principle)
@sergiocorato
Merge pull request #1 from tafaRU/12.0-fix-l10n_it_fatturapa_in-migr-1.6
3b72693 
l10n_it_fatturapa_in: avoid duplication in the code of post migration script (DRY principle)
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sergiocorato
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1914-by-sergiocorato-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 14, 2020
@OCA-git-bot
Merge PR #1914 into 12.0
0db09cb 
Signed-off-by sergiocorato
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-1914-by-sergiocorato-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 14, 2020
@OCA-git-bot
Merge PR #1914 into 12.0
c9074e6 
Signed-off-by sergiocorato
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-1914-by-sergiocorato-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 370e848 into OCA:12.0 Dec 15, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 843baac. Thanks a lot for contributing to OCA. ❤️

scigghia
scigghia reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@scigghia scigghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CiroBoxHub CiroBoxHub mentioned this pull request Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU approved these changes

@scigghia scigghia scigghia left review comments

@matteoopenf matteoopenf matteoopenf approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 no issue needed ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sergiocorato @matteoopenf @scigghia @OCA-git-bot @tafaRU @francesco-ooops