[12.0][FIX] fatturapa withholding tax invoice received e-invoice 1.6 #1878

sergiocorato · 2020-09-11T12:41:48Z

Descrizione del problema o della funzionalità:

Comportamento attuale prima di questa PR:

Comportamento desiderato dopo questa PR:

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

This reverts commit 421ef9e51634383263638e9b52ea4038829f62ec.

…tion, according to XML test file. Otherwise: 2020-09-17 07:34:14,789 7808 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_wt.tests.test_fatturapa_wt: ` AssertionError: b'<ns[1677 chars]a>RT02</TipoRitenuta><ImportoRitenuta>2.00</Im[1155 chars]ica>' != b'<ns[1677 chars]a>RT04</TipoRitenuta><ImportoRitenuta>0.83</Im[1155 chars]ica>'

…1878) * [12.0][FIX] fatturapa withholding tax invoice received - e-invoice 1.6 * [FIX] l10n_it_fatturapa_out_wt pep8 fixes This reverts commit 421ef9e51634383263638e9b52ea4038829f62ec. * [IMP] migration script * [FIX] l10n_it_fatturapa_out_wt: Fixed ordering in DatiRitenuta generation, according to XML test file. Otherwise: 2020-09-17 07:34:14,789 7808 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_wt.tests.test_fatturapa_wt: ` AssertionError: b'<ns[1677 chars]a>RT02</TipoRitenuta><ImportoRitenuta>2.00</Im[1155 chars]ica>' != b'<ns[1677 chars]a>RT04</TipoRitenuta><ImportoRitenuta>0.83</Im[1155 chars]ica>' Co-authored-by: SimoRubi <[email protected]>

…ther backports * [FIX] l10n_it_fatturapa: withholding tax invoice received - e-invoice 1.6 (OCA#1878) * [FIX] l10n_it_fatturapa_out_wt: pep8 fixes * [IMP] l10n_it_fatturapa_in: migration script * [FIX] l10n_it_fatturapa_out_wt: Fixed ordering in DatiRitenuta generation, according to XML test file.

tafaRU · 2020-10-16T13:27:14Z

l10n_it_fatturapa_in/migrations/12.0.1.19.0/post-migration.py

+            )
+            SELECT
+                ai.ftpa_withholding_type,
+                ai.ftpa_withholding_amount,


@sergiocorato il post migrated script viene eseguito dopo l'aggiornamento del modulo, di conseguenza questo campo ftpa_withholding_amount, nel momento dell'esecuzione dello script non è più presente: come fa pertanto a funzionare?

Su un nostro cliente che usa Odoo.sh otteniamo questo errore:

10/15/2020 16:00:29ERRORserverFailed to load registry Traceback (most recent call last): File "/home/odoo/src/odoo/odoo/modules/registry.py", line 86, in new odoo.modules.load_modules(registry._db, force_demo, status, update_module) File "/home/odoo/src/odoo/odoo/modules/loading.py", line 417, in load_modules force, status, report, loaded_modules, update_module, models_to_check) File "/home/odoo/src/odoo/odoo/modules/loading.py", line 313, in load_marked_modules perform_checks=perform_checks, models_to_check=models_to_check File "/home/odoo/src/odoo/odoo/modules/loading.py", line 227, in load_module_graph migrations.migrate_module(package, 'post') File "/home/odoo/src/odoo/odoo/modules/migration.py", line 190, in migrate_module migrate(self.cr, installed_version) File "/home/odoo/.local/lib/python3.6/site-packages/openupgradelib/openupgrade.py", line 1796, in wrapped_function if use_env2 else cr, version) File "/home/odoo/src/user/OCA/l10n-italy/l10n_it_fatturapa_in/migrations/12.0.1.19.0/post-migration.py", line 38, in migrate create_withholding_data_lines(env) File "/home/odoo/src/user/OCA/l10n-italy/l10n_it_fatturapa_in/migrations/12.0.1.19.0/post-migration.py", line 30, in create_withholding_data_lines """ File "/home/odoo/.local/lib/python3.6/site-packages/openupgradelib/openupgrade.py", line 1262, in logged_query cr.execute(query, args) File "/home/odoo/src/odoo/odoo/sql_db.py", line 148, in wrapper return f(self, *args, **kwargs) File "/home/odoo/src/odoo/odoo/sql_db.py", line 225, in execute res = self._obj.execute(query, params) psycopg2.ProgrammingError: column ai.ftpa_withholding_amount does not exist LINE 14: ai.ftpa_withholding_amount, ^

che mi pare riconducibile a quanto scrivo sopra. Condividi l'analisi o mi sta sfuggendo qualcosa?

Cioè chi lo elimina ftpa_withholding_amount? Odoo stesso quando rimuovi il campo dal model?

Io aggiornato a 12.0.2.0.0.99.dev2 ma a questo punto non so perchè abbia funzionato

Odoo stesso quando rimuovi il campo dal model?

eh sì

aggiornato a 12.0.2.0.0.99.dev2 ma a questo punto non so perchè abbia funzionato

cioè hai usato #1914? funziona perché lo script di migrazione controlla se tale campo esiste prima di effettuare la query.

Ho usato https://pypi.org/project/odoo12-addon-l10n-it-fatturapa-in/12.0.2.0.0.99.dev2/

Odoo stesso quando rimuovi il campo dal model?

Ho assunto di sì AFAIK, mi pare logico, @eLBati tu dici che non è così scontato? cc @sergiocorato

In effetti assumevo di no, forse in vecchie versioni era no. Ma magari ora è sì 🤯 😁

Sarebbe da provare

Si, se esiste la colonna ftpa_withholding_amount la copia e la usa, altrimenti fa solo la ftpa_withholding_type

…CA#1878) * [12.0][FIX] fatturapa withholding tax invoice received - e-invoice 1.6 * [FIX] l10n_it_fatturapa_out_wt pep8 fixes This reverts commit 421ef9e51634383263638e9b52ea4038829f62ec. * [IMP] migration script * [FIX] l10n_it_fatturapa_out_wt: Fixed ordering in DatiRitenuta generation, according to XML test file. Otherwise: 2020-09-17 07:34:14,789 7808 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_wt.tests.test_fatturapa_wt: ` AssertionError: b'<ns[1677 chars]a>RT02</TipoRitenuta><ImportoRitenuta>2.00</Im[1155 chars]ica>' != b'<ns[1677 chars]a>RT04</TipoRitenuta><ImportoRitenuta>0.83</Im[1155 chars]ica>' Co-authored-by: SimoRubi <[email protected]>

…ther backports * [FIX] l10n_it_fatturapa: withholding tax invoice received - e-invoice 1.6 (OCA#1878) * [FIX] l10n_it_fatturapa_out_wt: pep8 fixes * [IMP] l10n_it_fatturapa_in: migration script * [FIX] l10n_it_fatturapa_out_wt: Fixed ordering in DatiRitenuta generation, according to XML test file.

…CA#1878) * [12.0][FIX] fatturapa withholding tax invoice received - e-invoice 1.6 * [FIX] l10n_it_fatturapa_out_wt pep8 fixes This reverts commit 421ef9e51634383263638e9b52ea4038829f62ec. * [IMP] migration script * [FIX] l10n_it_fatturapa_out_wt: Fixed ordering in DatiRitenuta generation, according to XML test file. Otherwise: 2020-09-17 07:34:14,789 7808 ERROR openerp_test odoo.addons.l10n_it_fatturapa_out_wt.tests.test_fatturapa_wt: ` AssertionError: b'<ns[1677 chars]a>RT02</TipoRitenuta><ImportoRitenuta>2.00</Im[1155 chars]ica>' != b'<ns[1677 chars]a>RT04</TipoRitenuta><ImportoRitenuta>0.83</Im[1155 chars]ica>' Co-authored-by: SimoRubi <[email protected]>

sergiocorato force-pushed the 12.0-imp-fatturapa_withholding_tax_in_einvoice_1.6 branch from 73121c3 to a94e571 Compare September 11, 2020 12:49

sergiocorato mentioned this pull request Sep 11, 2020

[fatturazione elettronica 1.6] Ricezione fatture con ritenute #1877

Closed

3 tasks

sergiocorato force-pushed the 12.0-imp-fatturapa_withholding_tax_in_einvoice_1.6 branch 9 times, most recently from 86be759 to faf0490 Compare September 17, 2020 06:50

sergiocorato added 2 commits September 17, 2020 09:10

[12.0][FIX] fatturapa withholding tax invoice received - e-invoice 1.6

d16b663

[FIX] l10n_it_fatturapa_out_wt pep8 fixes

2cb72f6

This reverts commit 421ef9e51634383263638e9b52ea4038829f62ec.

sergiocorato force-pushed the 12.0-imp-fatturapa_withholding_tax_in_einvoice_1.6 branch from faf0490 to 2cb72f6 Compare September 17, 2020 07:10

[IMP] migration script

341db54

sergiocorato force-pushed the 12.0-imp-fatturapa_withholding_tax_in_einvoice_1.6 branch from 1067a9e to 341db54 Compare September 18, 2020 08:59

sergiocorato merged commit b391c95 into OCA:12.0-l10n_it_fatturapa-1.6 Sep 18, 2020

tafaRU reviewed Oct 16, 2020

View reviewed changes

salvorapi mentioned this pull request Jan 24, 2024

[16.0] l10n_it_riba: fix state update on riba lines #3885

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][FIX] fatturapa withholding tax invoice received e-invoice 1.6 #1878

[12.0][FIX] fatturapa withholding tax invoice received e-invoice 1.6 #1878

sergiocorato commented Sep 11, 2020

tafaRU Oct 16, 2020 •

edited

Loading

sergiocorato Oct 16, 2020

eLBati Oct 17, 2020

tafaRU Oct 19, 2020

eLBati Oct 20, 2020

tafaRU Oct 21, 2020 •

edited

Loading

eLBati Oct 22, 2020

sergiocorato Oct 22, 2020

[12.0][FIX] fatturapa withholding tax invoice received e-invoice 1.6 #1878

[12.0][FIX] fatturapa withholding tax invoice received e-invoice 1.6 #1878

Conversation

sergiocorato commented Sep 11, 2020

tafaRU Oct 16, 2020 • edited Loading

Choose a reason for hiding this comment

sergiocorato Oct 16, 2020

Choose a reason for hiding this comment

eLBati Oct 17, 2020

Choose a reason for hiding this comment

tafaRU Oct 19, 2020

Choose a reason for hiding this comment

eLBati Oct 20, 2020

Choose a reason for hiding this comment

tafaRU Oct 21, 2020 • edited Loading

Choose a reason for hiding this comment

eLBati Oct 22, 2020

Choose a reason for hiding this comment

sergiocorato Oct 22, 2020

Choose a reason for hiding this comment

tafaRU Oct 16, 2020 •

edited

Loading

tafaRU Oct 21, 2020 •

edited

Loading