[15.0][MIG] website_sale_order_type: Migration to version 15.0 #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, it's easy that the tour fails randomly due to a timeout when generating the sales order report. These assets can take a long time, increasing when more addons are installed.
In an integrated database, this patch makes the test go from this log:
2020-11-06 10:34:53,941 34 INFO devel werkzeug: 127.0.0.1 - - [06/Nov/2020 10:34:53] "POST /payment/transfer/feedback HTTP/1.1" 302 - 730 4.368 11.800
To this one:
2020-11-06 10:32:55,517 34 INFO devel werkzeug: 127.0.0.1 - - [06/Nov/2020 10:32:55] "POST /payment/transfer/feedback HTTP/1.1" 302 - 479 2.906 5.771
That's about 50% the time.
In the same patch, I remove the `self.env` patch that was only needed for Odoo v11 and lower.
With the old tour, timeout problems started to occur, even with 7830084 This partially reverts that, and instead uses a simpler tour to test the creation of the SO. TT26399
If we don't trigger the onchanges, we won't get some of the default values that the order type has defined TT30235
stefan-tecnativa
force-pushed
the
15.0-mig-website_sale_order_type
branch
from
ccd0593 to
4d86f09
Compare
CarlosRoca13
approved these changes
Dec 15, 2022
stefan-tecnativa
force-pushed
the
15.0-mig-website_sale_order_type
branch
from
4d86f09 to
d48bfcf
Compare
chienandalu
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Thanks @stefan-tecnativa ! 👍
@pilarvargas-tecnativa give your final approval, please 😉
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 27460c5. Thanks a lot for contributing to OCA. ❤️ |
pilarvargas-tecnativa
pushed a commit
to Tecnativa/e-commerce
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT37013
@chienandalu @CarlosRoca13 please review!